You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "devmadhuu (via GitHub)" <gi...@apache.org> on 2023/10/09 03:48:39 UTC
[PR] HDDS-7875. Intermittent failure in TestBlockOutputStream(FlushDelay). [ozone]
devmadhuu opened a new pull request, #5403:
URL: https://github.com/apache/ozone/pull/5403
## What changes were proposed in this pull request?
This PR fixes the inconsistent and unstable assertion being done which is related to count of pending container operation count metrics for `WriteChunk` and `PutBlock` operations. Pending container operation count metrics for each operation is stored in `pendingOpsArray` array and metric count of each operation gets incremented and decremented based on operation start and completion and since the operation is Async operation , this metric can be very inconsistent to be predicted correctly and assert in test, so we should assert total operation count metric which this PR is taking care in all related test cases.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7875
## How was this patch tested?
This patch is tested with multiple iterations of running each test case and removed flaky annotation. Here is the [green CI link](https://github.com/devmadhuu/ozone/actions/runs/6433750887) over forked branch with 2 attempts of same multiple iterations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-7875. Intermittent failure in TestBlockOutputStream(FlushDelay). [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #5403:
URL: https://github.com/apache/ozone/pull/5403#issuecomment-1770964501
Thanks @devmadhuu for the patch, @kerneltime for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-7875. Intermittent failure in TestBlockOutputStream(FlushDelay). [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #5403:
URL: https://github.com/apache/ozone/pull/5403
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-7875. Intermittent failure in TestBlockOutputStream(FlushDelay). [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #5403:
URL: https://github.com/apache/ozone/pull/5403#issuecomment-1769233430
On second look: the issue also covers `TestBlockOutputStream`, can you please also test that one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-7875. Intermittent failure in TestBlockOutputStream(FlushDelay). [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #5403:
URL: https://github.com/apache/ozone/pull/5403#issuecomment-1759219364
@devmadhuu `TestOMRatisSnapshots` fork timeout is fixed since then, please merge `master` into your branch to get a new CI run
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-7875. Intermittent failure in TestBlockOutputStream(FlushDelay). [ozone]
Posted by "devmadhuu (via GitHub)" <gi...@apache.org>.
devmadhuu commented on PR #5403:
URL: https://github.com/apache/ozone/pull/5403#issuecomment-1770743995
> On second look: the issue also covers `TestBlockOutputStream`, can you please also test that one?
Thanks @adoroszlai for pointing out, I fixed the timeout issue in TestBlockOutputStream. Here is [green CI link](https://github.com/devmadhuu/ozone/actions/runs/6569895068) after the fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-7875. Intermittent failure in TestBlockOutputStream(FlushDelay). [ozone]
Posted by "devmadhuu (via GitHub)" <gi...@apache.org>.
devmadhuu commented on PR #5403:
URL: https://github.com/apache/ozone/pull/5403#issuecomment-1752397742
@adoroszlai @sumitagrawl Pls review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org