You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "John Sichi (JIRA)" <ji...@apache.org> on 2010/01/11 22:45:54 UTC

[jira] Updated: (HIVE-1040) use sed rather than diff for masking out noise in diff-based tests

     [ https://issues.apache.org/jira/browse/HIVE-1040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

John Sichi updated HIVE-1040:
-----------------------------

    Priority: Minor  (was: Major)

> use sed rather than diff for masking out noise in diff-based tests
> ------------------------------------------------------------------
>
>                 Key: HIVE-1040
>                 URL: https://issues.apache.org/jira/browse/HIVE-1040
>             Project: Hadoop Hive
>          Issue Type: Improvement
>          Components: Testing Infrastructure
>    Affects Versions: 0.4.1
>            Reporter: John Sichi
>            Priority: Minor
>
> The current diff -I approach has two problems:  (1) it does not allow resolution finer than line-level, so it's impossible to mask out pattern occurrences within a line, and (2) it produces unmasked files, so if you run diff on the command line to compare the result .q.out with the checked-in file, you see the noise.
> My suggestion is to first run sed to replace noise patterns with an unlikely-to-occur string like ZYZZYZVA, and then diff the pre-masked files without using any -I.
> This would require a one-time hit to update all existing .q.out files so that they would contain the pre-masked results.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.