You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by jpountz <gi...@git.apache.org> on 2018/04/05 12:32:36 UTC

[GitHub] lucene-solr pull request #345: LUCENE-8229: Add Weight.matches() method

Github user jpountz commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/345#discussion_r179443149
  
    --- Diff: solr/core/src/java/org/apache/solr/update/DeleteByQueryWrapper.java ---
    @@ -77,6 +78,11 @@ public void extractTerms(Set<Term> terms) {
             throw new UnsupportedOperationException();
           }
     
    +      @Override
    +      public Matches matches(LeafReaderContext context, int doc) throws IOException {
    +        return Matches.emptyMatches(context, doc, this, "*");  // TODO is there a way of reporting matches that makes sense here?
    --- End diff --
    
    let's just throw an UOE?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org