[GitHub] [incubator-openwhisk] markusthoemmes commented on a change in pull request #4388: Adapt limit to query db view as per couch db change

[GitBox <gi...@apache.org>]

markusthoemmes commented on a change in pull request #4388: Adapt limit to query db view as per couch db change
URL: https://github.com/apache/incubator-openwhisk/pull/4388#discussion_r268192937
 
 

 ##########
 File path: core/invoker/src/main/scala/org/apache/openwhisk/core/invoker/NamespaceBlacklist.scala
 ##########
 @@ -38,6 +38,9 @@ class NamespaceBlacklist(authStore: AuthStore) {
 
   private var blacklist: Set[String] = Set.empty
 
+  // Enforced by couchdb, max limit value for db view query
+  private var couchdb_limit: Int = 268435456
 
 Review comment:
   This should be a `val` and as it's a constant should be written in all caps, like `COUCHDB_LIMIT`.
   
   However, I feel like this should be factored into the couchdb code itself and the `limit` value should have an upper-bound applied there. Technically you do not know in this piece of code that you're handling CouchDB.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services