[GitHub] [flink] yangjunhan commented on a diff in pull request #20212: [FLINK-28314][runtime-web] introduce "Cluster Environment" tab under history server

[GitBox <gi...@apache.org>]

yangjunhan commented on code in PR #20212:
URL: https://github.com/apache/flink/pull/20212#discussion_r917495555


##########
flink-runtime-web/web-dashboard/src/app/app.component.html:
##########
@@ -58,29 +58,31 @@ <h1>Apache Flink Dashboard</h1>
           </li>
         </ul>
       </li>
-      <li nz-menu-item routerLinkActive="ant-menu-item-selected" [routerLink]="['/task-manager']">
-        <span>
-          <i nz-icon nzType="schedule"></i>
-          <span>Task Managers</span>
-        </span>
-      </li>
-      <li nz-menu-item routerLinkActive="ant-menu-item-selected" [routerLink]="['/job-manager']">
-        <span>
-          <i nz-icon nzType="build"></i>
-          <span>Job Manager</span>
-        </span>
-      </li>
-      <li
-        *ngIf="webSubmitEnabled"
-        nz-menu-item
-        routerLinkActive="ant-menu-item-selected"
-        [routerLink]="['/submit']"
-      >
-        <span>
-          <i nz-icon nzType="upload"></i>
-          <span>Submit New Job</span>
-        </span>
-      </li>
+      <ng-container *ngIf="!historyServerEnv">
+        <li nz-menu-item routerLinkActive="ant-menu-item-selected" [routerLink]="['/task-manager']">
+          <span>

Review Comment:
   The purpose of hiding these menu items is to make our pages cleaner because JM and TM are unavailable under History Server (just an improvement). It is unnecessary to create a route guard to prevent entering these pages which should display nothing :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org