You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by "Peter N. Lundblad" <pe...@famlundblad.se> on 2005/11/07 07:22:46 UTC
Re: svn trunk r17226: FAIL (x86_64-unknown-linux-gnu static ra_local
bdb)
> EXPECTED STDOUT:
> Sending svn-test-work/working_copies/commit_tests-34/iota
> Transmitting file data .
> Committed revision 2.
>
> Warning:'post-commit' hook failed with error output:
> Post-commit Hook says nothing doing on stderr
>
> ACTUAL STDOUT:
> Sending svn-test-work/working_copies/commit_tests-34/iota
> Transmitting file data .
> Committed revision 2.
>
> Warning:'post-commit' hook failed with error output:
> /svntest/obj-st/subversion/tests/clients/cmdline/svn-test-work/repositories/commit_tests-34/hooks/post-commit: line 2: /dev/stderr: Permission denied
>
> EXCEPTION: SVNLineUnequal
> FAIL: commit_tests.py 34: post commit hook failure case testing
Is this some kind of configuration error on the test machine? (Why the
post-commit error was written to stdout instead of stderr is another
question that should probably be posted separately...)
thanks,
//Peter
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: post-commit error printet to stdout (was: Re: svn trunk r17226: FAIL (x86_64-unknown-linux-gnu static ra_local bdb))
Posted by Garrett Rooney <ro...@electricjellyfish.net>.
On 11/7/05, Peter N. Lundblad <pe...@famlundblad.se> wrote:
> Fun. I looked in the file, but didmiss that comment. Sometimes using a
> one-line braille display shows up:-)
> This was committed recently as part of 443.
>
> Is the above statement really valid? We print other warnings to stderr. If
> someone wants to know if the commit failed, then they should use the exit
> status IMO. Hmmm, and then we have the proposal that warnings should also
> set a non-zero exit status... I still don't think printing this particular
> warning to stdout is a good idea. The commit has succeded, but you don't
> know how severe the post-commit failure is.
I don't feel strongly one way or the other on this. If we are sending
other warnings to stderr I guess it does make sense to treat this the
same way though.
Madan, since you wrote that code, what do you think?
-garrett
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
post-commit error printet to stdout (was: Re: svn trunk r17226: FAIL
(x86_64-unknown-linux-gnu static ra_local bdb))
Posted by "Peter N. Lundblad" <pe...@famlundblad.se>.
On Mon, 7 Nov 2005, Malcolm Rowe wrote:
> On Mon, Nov 07, 2005 at 08:22:46AM +0100, Peter N. Lundblad wrote:
> > Why the
> > post-commit error was written to stdout instead of stderr is another
> > question that should probably be posted separately...)
>
> See svn_cl__print_commit_info().
>
> /* Writing to stdout, as there maybe systems that consider the
> * presence of stderr as an indication of commit failure.
> * OTOH, this is only of informational nature to the user as
> * the commit has succeeded. */
>
Fun. I looked in the file, but didmiss that comment. Sometimes using a
one-line braille display shows up:-)
This was committed recently as part of 443.
Is the above statement really valid? We print other warnings to stderr. If
someone wants to know if the commit failed, then they should use the exit
status IMO. Hmmm, and then we have the proposal that warnings should also
set a non-zero exit status... I still don't think printing this particular
warning to stdout is a good idea. The commit has succeded, but you don't
know how severe the post-commit failure is.
Regards,
//Peter
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn trunk r17226: FAIL (x86_64-unknown-linux-gnu static ra_local bdb)
Posted by Malcolm Rowe <ma...@farside.org.uk>.
On Mon, Nov 07, 2005 at 08:22:46AM +0100, Peter N. Lundblad wrote:
> Why the
> post-commit error was written to stdout instead of stderr is another
> question that should probably be posted separately...)
See svn_cl__print_commit_info().
/* Writing to stdout, as there maybe systems that consider the
* presence of stderr as an indication of commit failure.
* OTOH, this is only of informational nature to the user as
* the commit has succeeded. */
Regards,
Malcolm
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org