You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@uniffle.apache.org by ck...@apache.org on 2023/01/27 08:11:39 UTC

[incubator-uniffle] branch master updated: [Deps] Switch to slf4j-reload4j (#508)

This is an automated email from the ASF dual-hosted git repository.

ckj pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-uniffle.git


The following commit(s) were added to refs/heads/master by this push:
     new 33c4fe42 [Deps] Switch to slf4j-reload4j (#508)
33c4fe42 is described below

commit 33c4fe4208b640a71d4ecbb2f9ad3f20f4ba1cc9
Author: Kaijie Chen <ck...@apache.org>
AuthorDate: Fri Jan 27 16:11:34 2023 +0800

    [Deps] Switch to slf4j-reload4j (#508)
    
    ### What changes were proposed in this pull request?
    
    1. Replace `slf4j-log4j12` with `slf4j-reload4j`.
    2. Change dependency scope to `runtime`.
    
    ### Why are the changes needed?
    
    Eliminate this warning from maven:
    
    ```
    [WARNING] While downloading org.slf4j:slf4j-log4j12:1.7.36
      This artifact has been relocated to org.slf4j:slf4j-reload4j:1.7.36.
    ```
    
    ### Does this PR introduce _any_ user-facing change?
    
    No.
    
    ### How was this patch tested?
    
    CI.
---
 common/pom.xml | 4 ++++
 pom.xml        | 5 +++--
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/common/pom.xml b/common/pom.xml
index 70ab0c6c..60a2418e 100644
--- a/common/pom.xml
+++ b/common/pom.xml
@@ -114,6 +114,10 @@
       <artifactId>snappy-java</artifactId>
       <scope>provided</scope>
     </dependency>
+    <dependency>
+      <groupId>org.slf4j</groupId>
+      <artifactId>slf4j-api</artifactId>
+    </dependency>
   </dependencies>
 
   <build>
diff --git a/pom.xml b/pom.xml
index 7bcd792b..eeab2547 100644
--- a/pom.xml
+++ b/pom.xml
@@ -120,7 +120,7 @@
   <dependencies>
     <dependency>
       <groupId>org.slf4j</groupId>
-      <artifactId>slf4j-log4j12</artifactId>
+      <artifactId>slf4j-reload4j</artifactId>
     </dependency>
 
     <dependency>
@@ -154,8 +154,9 @@
     <dependencies>
       <dependency>
         <groupId>org.slf4j</groupId>
-        <artifactId>slf4j-log4j12</artifactId>
+        <artifactId>slf4j-reload4j</artifactId>
         <version>${slf4j.version}</version>
+        <scope>runtime</scope>
       </dependency>
 
       <dependency>