[GitHub] [skywalking-query-protocol] mrproliu commented on a diff in pull request #98: Support query process relation metrics

[GitBox <gi...@apache.org>]

mrproliu commented on code in PR #98:
URL: https://github.com/apache/skywalking-query-protocol/pull/98#discussion_r918053707


##########
topology.graphqls:
##########
@@ -91,6 +91,14 @@ type EndpointNode {
 type ProcessNode {
     # The process id of each node.
     id: ID!
+    # Service id
+    serviceId: ID!
+    # The literal name of the #serviceId.
+    serviceName: String!
+    # Service Instance id
+    serviceInstanceId: ID!
+    # The literal name of the #serviceInstanceId.
+    serviceInstanceName: String!

Review Comment:
   Yes, these fields are present whether they are actual nodes or not, and help to query the metrics.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org