You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Christopher Conrad <cc...@valinux.com> on 2001/07/24 16:56:49 UTC

Issue #402

Hi,

I'm new to subversion and thought I'd work on one of the bite sized tasks to
get my feet wet with the code.  I basically have a patch done for issue
402.  Right now

svn --no-such-option -> stderr, non-zero exit code
svn --help -> stdout, zero exit code

How should
svn help
work?  Technically, it's an error because help requires the command you're
requesting help for; but what does everyone else think?

--Chris

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: Issue #402

Posted by cm...@collab.net.
kfogel@collab.net writes:

> Thanks, Chris!
> 
> My thought is that "svn help" is not an error; after all, it gives you
> help either way.  If you don't give a command, "help" gives you help
> on itself.  If you do, it gives you help on that command.
> 
> In general, I don't think we should exit with failure status unless
> there's something actually wrong; here, nothing is wrong imho.

Heh.  It didn't even occur to me that help could give help on itself.
I retract my earlier statement.  :-)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: Issue #402

Posted by kf...@collab.net.
Christopher Conrad <cc...@valinux.com> writes:
> I'm new to subversion and thought I'd work on one of the bite sized tasks to
> get my feet wet with the code.  I basically have a patch done for issue
> 402.  Right now
> 
> svn --no-such-option -> stderr, non-zero exit code
> svn --help -> stdout, zero exit code
> 
> How should
> svn help
> work?  Technically, it's an error because help requires the command you're
> requesting help for; but what does everyone else think?

Thanks, Chris!

My thought is that "svn help" is not an error; after all, it gives you
help either way.  If you don't give a command, "help" gives you help
on itself.  If you do, it gives you help on that command.

In general, I don't think we should exit with failure status unless
there's something actually wrong; here, nothing is wrong imho.

-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: Issue #402

Posted by cm...@collab.net.
Christopher Conrad <cc...@valinux.com> writes:

> I'm new to subversion and thought I'd work on one of the bite sized tasks to
> get my feet wet with the code.  I basically have a patch done for issue
> 402.

Woohoo!!  Thanks, Christopher!

> How should svn help work?  Technically, it's an error because help
> requires the command you're requesting help for; but what does
> everyone else think?

I agree with you.  `svn help' is different from `svn --help' in that
it requires a subcommand.  I'd say treat it like an error.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: Issue #402

Posted by Tripp Lilley <tl...@perspex.com>.
On Tue, 24 Jul 2001, Christopher Conrad wrote:

> How should svn help work?  Technically, it's an error because help
> requires the command you're requesting help for; but what does everyone
> else think? 

As a datapoint, "p4 help" lists the possible invocations of "p4 help ..."
to stdout. If you invoke "p4 help ..." with a command name or help
subtopic that doesn't exist, then it prints an error to stderr:

[tlilley@charmin 20010424-01]$ p4 help

    Perforce -- the Fast Software Configuration Management System.

    p4 is Perforce's client tool for the command line.  Try:

	p4 help simple        list most common commands
	p4 help commands      list all commands
	p4 help command       help on a specific command
	p4 help environment   list environment and registry variables
	p4 help filetypes     list supported file types
	p4 help jobview       help on jobview syntax
	p4 help revisions     help on specifying file revisions
	p4 help usage         generic command line arguments
	p4 help views         help on view syntax

    The full user manual is available at http://www.perforce.com/manual.

    Server 2000.2/19520.

[tlilley@charmin 20010424-01]$ p4 help > /dev/null
[tlilley@charmin 20010424-01]$ p4 help ficus > /dev/null
No help for ficus.
[tlilley@charmin 20010424-01]$ 



-- 
   Tripp Lilley  *  http://stargate.eheart.sg505.net/~tlilley/
--------------------------------------------------------------------------
   "The human soul is the greatest anti-piracy measure in the known
    world, but no major company will use it."

   <http://slashdot.org/comments.pl?sid=01/07/19/007240&cid=94>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org