You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/10/28 08:52:31 UTC
[GitHub] [apisix] monkeyDluffy6017 opened a new pull request, #8200: bugfix: can not modify x-forwarded-host in proxy rewrite
monkeyDluffy6017 opened a new pull request, #8200:
URL: https://github.com/apache/apisix/pull/8200
### Description
fix can not modify x-forwarded-host in proxy rewrite
### Checklist
- [x] I have explained the need for this PR and the problem it solves
- [x] I have explained the changes or the new features added to this PR
- [x] I have added tests corresponding to this change
- [ ] I have updated the documentation to reflect this change
- [x] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tokers commented on a diff in pull request #8200: fix: can not modify x-forwarded-host in proxy rewrite
Posted by GitBox <gi...@apache.org>.
tokers commented on code in PR #8200:
URL: https://github.com/apache/apisix/pull/8200#discussion_r1009990686
##########
t/plugin/proxy-rewrite.t:
##########
@@ -34,7 +34,61 @@ run_tests;
__DATA__
-=== TEST 1: sanity
+=== TEST 1: set route(rewrite host)
Review Comment:
This case is samiliar to the one in proxy-rewrite-3.t?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a diff in pull request #8200: fix: can not modify x-forwarded-host in proxy rewrite
Posted by GitBox <gi...@apache.org>.
spacewander commented on code in PR #8200:
URL: https://github.com/apache/apisix/pull/8200#discussion_r1009069289
##########
t/plugin/proxy-rewrite.t:
##########
@@ -1311,3 +1311,56 @@ host: test.com:6443
x-real-ip: 127.0.0.1
--- no_error_log
[error]
+
+
+
+=== TEST 45: set route(rewrite host)
+--- config
Review Comment:
Let's add new test to https://github.com/apache/apisix/blob/master/t/plugin/proxy-rewrite3.t
##########
t/plugin/proxy-rewrite.t:
##########
@@ -1311,3 +1311,56 @@ host: test.com:6443
x-real-ip: 127.0.0.1
--- no_error_log
[error]
+
+
+
+=== TEST 45: set route(rewrite host)
Review Comment:
The title is incorrect. We don't rewrite the host
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] monkeyDluffy6017 commented on a diff in pull request #8200: fix: can not modify x-forwarded-host in proxy rewrite
Posted by GitBox <gi...@apache.org>.
monkeyDluffy6017 commented on code in PR #8200:
URL: https://github.com/apache/apisix/pull/8200#discussion_r1011068949
##########
t/plugin/proxy-rewrite.t:
##########
@@ -34,7 +34,61 @@ run_tests;
__DATA__
-=== TEST 1: sanity
+=== TEST 1: set route(rewrite host)
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #8200: fix: can not modify x-forwarded-host in proxy rewrite
Posted by GitBox <gi...@apache.org>.
spacewander merged PR #8200:
URL: https://github.com/apache/apisix/pull/8200
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] monkeyDluffy6017 commented on a diff in pull request #8200: fix: can not modify x-forwarded-host in proxy rewrite
Posted by GitBox <gi...@apache.org>.
monkeyDluffy6017 commented on code in PR #8200:
URL: https://github.com/apache/apisix/pull/8200#discussion_r1009613076
##########
t/plugin/proxy-rewrite.t:
##########
@@ -1311,3 +1311,56 @@ host: test.com:6443
x-real-ip: 127.0.0.1
--- no_error_log
[error]
+
+
+
+=== TEST 45: set route(rewrite host)
+--- config
Review Comment:
Done
##########
t/plugin/proxy-rewrite.t:
##########
@@ -1311,3 +1311,56 @@ host: test.com:6443
x-real-ip: 127.0.0.1
--- no_error_log
[error]
+
+
+
+=== TEST 45: set route(rewrite host)
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org