You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/05/07 01:30:50 UTC

[GitHub] [trafficserver] masaori335 commented on a change in pull request #7795: Make HTTP/2 configs reloadable

masaori335 commented on a change in pull request #7795:
URL: https://github.com/apache/trafficserver/pull/7795#discussion_r627865170



##########
File path: proxy/http2/Http2Frame.cc
##########
@@ -76,11 +76,6 @@ Http2DataFrame::write_to(MIOBuffer *iobuffer) const
 int64_t
 Http2HeadersFrame::write_to(MIOBuffer *iobuffer) const
 {
-  // Validation

Review comment:
       I just got rid of this validation, because the `_hdr_block_len` is already checked before making `Http2HeadersFrame` and too noisy to read or pass the config from `ua_session` here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org