[jira] [Commented] (TINKERPOP3-903) Fix empty buffer return upon buffer capacity exceeded

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TINKERPOP3-903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14966650#comment-14966650 ] 

ASF GitHub Bot commented on TINKERPOP3-903:
-------------------------------------------

Github user spmallette commented on the pull request:

    https://github.com/apache/incubator-tinkerpop/pull/114#issuecomment-149858993
  
    Created an issue in JIRA to tie this to:
    
    https://issues.apache.org/jira/browse/TINKERPOP3-903
    
    @okram note that i think @christianbellinaef only ran Gremlin Server integration tests.  I wouldn't anticipate problems though with spark as the code that was changed is related to serializing Gremlin Server request/response messages which I don't think have much to do with spark.
    
    One of these days I'm going to know when to flush and when not to :toilet: 
    
    In the future, please watch your IDE settings - as a point of code style TinkerPop code doesn't use wildcarded imports:
    
    https://github.com/apache/incubator-tinkerpop/pull/114/files#diff-c68ab1009a5e6ce5daaf5f10349a34eeR52
    
    I'll fix that up on the merge and update CHANGELOG.
    
    I ran `mvn clean install` and integration tests for Gremlin Server and they seem to work ok.
    
    VOTE: +1 (binding)
    
    @pluradj do you have some time to give us the final vote we need to get this merged?
    
    



> Fix empty buffer return upon buffer capacity exceeded
> -----------------------------------------------------
>
>                 Key: TINKERPOP3-903
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP3-903
>             Project: TinkerPop 3
>          Issue Type: Bug
>          Components: driver, server
>    Affects Versions: 3.0.2-incubating
>            Reporter: stephen mallette
>            Assignee: stephen mallette
>             Fix For: 3.1.0-incubating
>
>
> Discussion: https://groups.google.com/forum/#!topic/gremlin-users/zWGAn-oS5PQ
> Return the underlying byte array output stream which will always contain the full serialized object.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)