[GitHub] [incubator-mxnet] wkcn commented on a change in pull request #15921: dynamic custom operator support

[GitBox <gi...@apache.org>]

wkcn commented on a change in pull request #15921: dynamic custom operator support
URL: https://github.com/apache/incubator-mxnet/pull/15921#discussion_r355268745
 
 

 ##########
 File path: tests/python/unittest/test_extensions.py
 ##########
 @@ -21,15 +21,16 @@
 import platform
 import unittest
 import mxnet as mx
+import numpy as np
 from mxnet.base import MXNetError
-from mxnet.test_utils import download, is_cd_run
+from mxnet.test_utils import download, is_cd_run, assert_almost_equal
 
 def check_platform():
     return platform.machine() not in ['x86_64', 'AMD64']
 
 @unittest.skipIf(check_platform(), "not all machine types supported")
 @unittest.skipIf(is_cd_run(), "continuous delivery run - ignoring test")
-def test_library_loading():
+def test_custom_op():
 
 Review comment:
   Is it possible to use mx.libinfo.find_lib_path to find the library?
   https://github.com/apache/incubator-mxnet/blob/93228649340bcacb8056d47d8f6f8a78a9805ae4/python/mxnet/libinfo.py#L26

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services