[GitHub] [jackrabbit-oak] fabriziofortino commented on a change in pull request #399: OAK-9603: fix index name management in oak-search-elastic

[GitBox <gi...@apache.org>]

fabriziofortino commented on a change in pull request #399:
URL: https://github.com/apache/jackrabbit-oak/pull/399#discussion_r736444261



##########
File path: oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/ElasticIndexNameHelper.java
##########
@@ -98,8 +75,8 @@ public static String getRemoteIndexName(ElasticIndexDefinition indexDefinition)
      * <p>
      * The resulting file name would be truncated to MAX_NAME_LENGTH
      */
-    private static String getElasticSafeIndexName(String indexPath) {
-        String name = StreamSupport
+    public static String getElasticSafeIndexName(String indexPrefix, String indexPath) {
+        String name = indexPrefix + "." + StreamSupport

Review comment:
       The check on the `indexPrefix` is performed in the `ElasticConnection` init phase (called once when the `ElasticProviderService` gets initialized). I did not add the check here because this method is called frequently.
   I could (1) add the check anyway (2) add a comment to explain why the prefix does not need to be checked. I prefer option 2. What do you think?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org