You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Alex Huang <Al...@citrix.com> on 2013/07/12 02:36:58 UTC
Adding git commit ids to our packaging...
Hi All,
I added the branch and git commit id to the war file. You can find it by opening the war file and retrieving the META-INF/MANIFEST.MF. Inside, there is a Implementation-Revision which contains the git commit id and a Implementation-Branch which contains the branch.
We should add these to all of our jira issues so developers can easily figure out the revision being tested and work appropriately.
I will also cherry-pick this to 4.2. I assume there's no objections.
--Alex
Re: Adding git commit ids to our packaging...
Posted by Rohit Yadav <bh...@apache.org>.
+1 Would help users verify the git sha and for reference.
Cheers.
On Fri, Jul 12, 2013 at 6:06 AM, Alex Huang <Al...@citrix.com> wrote:
> Hi All,
>
> I added the branch and git commit id to the war file. You can find it by
> opening the war file and retrieving the META-INF/MANIFEST.MF. Inside,
> there is a Implementation-Revision which contains the git commit id and a
> Implementation-Branch which contains the branch.
>
> We should add these to all of our jira issues so developers can easily
> figure out the revision being tested and work appropriately.
>
> I will also cherry-pick this to 4.2. I assume there's no objections.
>
> --Alex
>
Re: Adding git commit ids to our packaging...
Posted by Prasanna Santhanam <ts...@apache.org>.
Alex - would it be difficult to have this come out from a command
line? Would we need to extract the jar/war each time? I want this
included in our automated test reports.
On Fri, Jul 12, 2013 at 05:28:51PM +0000, Alex Huang wrote:
> I think it should be in both. In fact, I am hoping to push them further down.
>
> Before our switch to git, the build number, which with svn included
> the revision as the last octet, was pushed to every script,
> javascript, jar, and war. I like to see that back again. It's very
> useful when trying to figure out exactly what was deployed. I will
> work toward that if there's no objections.
>
> I pushed in the changes to war file for now so QAs at least have
> some way to find the revision number to communicate in Jira.
>
> --Alex
>
> > -----Original Message-----
> > From: Chip Childers [mailto:chip.childers@sungard.com]
> > Sent: Friday, July 12, 2013 6:53 AM
> > To: dev@cloudstack.apache.org
> > Subject: Re: Adding git commit ids to our packaging...
> >
> > On Fri, Jul 12, 2013 at 09:48:12AM -0400, David Nalley wrote:
> > > On Thu, Jul 11, 2013 at 11:05 PM, Alex Huang <Al...@citrix.com>
> > wrote:
> > > > Will work on making it nicer but do we want to put this information into
> > release? Is there any harm to have this in the release build? I can't think of
> > any off-hand. If we don't want them, we can change build_asf.sh to set
> > those two variables to something nicer. If we want them, I might be able to
> > get it to read this information from a file instead.
> > > >
> > > > --Alex
> > > >
> > >
> > > Thanks for putting the work in to get this done.
> > > I agree - no harm in having this in the release build, and could be
> > > very useful to boot.
> > > I personally would like to see this information, present - setting it
> > > at tarball creation makes sense to me.
> > >
> > > --David
> > >
> >
> > +1
> >
> > The only reason it was removed previously was that it was breaking the build
> > process when someone tried to build from the release tarball. If we want to
> > drop the details into the release archive before tar'ing, great!
> >
> > The only other minor concern would be the release verification process will
> > have to be updated to account for the fact that we'll have one file (or some
> > lines) that are different between the actual tagged commit in the repo and
> > what's in the tarball. As far as I know, that's just a process change for us.
> > Easy...
> >
> > -chip
--
Prasanna.,
------------------------
Powered by BigRock.com
RE: Adding git commit ids to our packaging...
Posted by Alex Huang <Al...@citrix.com>.
I think it should be in both. In fact, I am hoping to push them further down.
Before our switch to git, the build number, which with svn included the revision as the last octet, was pushed to every script, javascript, jar, and war. I like to see that back again. It's very useful when trying to figure out exactly what was deployed. I will work toward that if there's no objections.
I pushed in the changes to war file for now so QAs at least have some way to find the revision number to communicate in Jira.
--Alex
> -----Original Message-----
> From: Chip Childers [mailto:chip.childers@sungard.com]
> Sent: Friday, July 12, 2013 6:53 AM
> To: dev@cloudstack.apache.org
> Subject: Re: Adding git commit ids to our packaging...
>
> On Fri, Jul 12, 2013 at 09:48:12AM -0400, David Nalley wrote:
> > On Thu, Jul 11, 2013 at 11:05 PM, Alex Huang <Al...@citrix.com>
> wrote:
> > > Will work on making it nicer but do we want to put this information into
> release? Is there any harm to have this in the release build? I can't think of
> any off-hand. If we don't want them, we can change build_asf.sh to set
> those two variables to something nicer. If we want them, I might be able to
> get it to read this information from a file instead.
> > >
> > > --Alex
> > >
> >
> > Thanks for putting the work in to get this done.
> > I agree - no harm in having this in the release build, and could be
> > very useful to boot.
> > I personally would like to see this information, present - setting it
> > at tarball creation makes sense to me.
> >
> > --David
> >
>
> +1
>
> The only reason it was removed previously was that it was breaking the build
> process when someone tried to build from the release tarball. If we want to
> drop the details into the release archive before tar'ing, great!
>
> The only other minor concern would be the release verification process will
> have to be updated to account for the fact that we'll have one file (or some
> lines) that are different between the actual tagged commit in the repo and
> what's in the tarball. As far as I know, that's just a process change for us.
> Easy...
>
> -chip
Re: Adding git commit ids to our packaging...
Posted by Chip Childers <ch...@sungard.com>.
On Fri, Jul 12, 2013 at 09:48:12AM -0400, David Nalley wrote:
> On Thu, Jul 11, 2013 at 11:05 PM, Alex Huang <Al...@citrix.com> wrote:
> > Will work on making it nicer but do we want to put this information into release? Is there any harm to have this in the release build? I can't think of any off-hand. If we don't want them, we can change build_asf.sh to set those two variables to something nicer. If we want them, I might be able to get it to read this information from a file instead.
> >
> > --Alex
> >
>
> Thanks for putting the work in to get this done.
> I agree - no harm in having this in the release build, and could be
> very useful to boot.
> I personally would like to see this information, present - setting it
> at tarball creation makes sense to me.
>
> --David
>
+1
The only reason it was removed previously was that it was breaking the
build process when someone tried to build from the release tarball. If
we want to drop the details into the release archive before tar'ing,
great!
The only other minor concern would be the release verification process
will have to be updated to account for the fact that we'll have one file
(or some lines) that are different between the actual tagged commit in
the repo and what's in the tarball. As far as I know, that's just a
process change for us. Easy...
-chip
Re: Adding git commit ids to our packaging...
Posted by David Nalley <da...@gnsa.us>.
On Thu, Jul 11, 2013 at 11:05 PM, Alex Huang <Al...@citrix.com> wrote:
> Will work on making it nicer but do we want to put this information into release? Is there any harm to have this in the release build? I can't think of any off-hand. If we don't want them, we can change build_asf.sh to set those two variables to something nicer. If we want them, I might be able to get it to read this information from a file instead.
>
> --Alex
>
Thanks for putting the work in to get this done.
I agree - no harm in having this in the release build, and could be
very useful to boot.
I personally would like to see this information, present - setting it
at tarball creation makes sense to me.
--David
RE: Adding git commit ids to our packaging...
Posted by Alex Huang <Al...@citrix.com>.
Will work on making it nicer but do we want to put this information into release? Is there any harm to have this in the release build? I can't think of any off-hand. If we don't want them, we can change build_asf.sh to set those two variables to something nicer. If we want them, I might be able to get it to read this information from a file instead.
--Alex
> -----Original Message-----
> From: Chip Childers [mailto:chip.childers@sungard.com]
> Sent: Thursday, July 11, 2013 6:35 PM
> To: <de...@cloudstack.apache.org>
> Subject: Re: Adding git commit ids to our packaging...
>
> Cool. +1 then
>
> On Jul 11, 2013, at 9:28 PM, David Nalley <da...@gnsa.us> wrote:
>
> > I was worried about the same thing, but ran build_asf.sh to create a
> > tarball and then built it.
> >
> > Here's the resulting output, which isn't perfectly nice, but also isn't broken.
> >
> > ke4qqq@mba
> > ~/apache-cloudstack-4.2.0-RC2-src/client/target/META-INF[master*]$
> > cat MANIFEST.MF
> > Manifest-Version: 1.0
> > Implementation-Vendor: The Apache Software Foundation
> > Implementation-Title: Apache CloudStack Client UI
> > Implementation-Version: 4.2.0-RC2
> > Implementation-Revision: UNKNOWN_REVISION
> > Implementation-Vendor-Id: org.apache.cloudstack
> > Built-By: ke4qqq
> > Build-Jdk: 1.7.0_09-icedtea
> > Created-By: Apache Maven 3.0.4
> > Implementation-Branch: UNKNOWN_BRANCH
> > Archiver-Version: Plexus Archiver
> >
> > --David
> >
> > On Thu, Jul 11, 2013 at 9:01 PM, Chip Childers
> > <ch...@sungard.com> wrote:
> >> Is it off by default?
> >>
> >> Our releases aren't from git.
> >>
> >> On Jul 11, 2013, at 8:38 PM, Alex Huang <Al...@citrix.com> wrote:
> >>
> >>> Hi All,
> >>>
> >>> I added the branch and git commit id to the war file. You can find it by
> opening the war file and retrieving the META-INF/MANIFEST.MF. Inside,
> there is a Implementation-Revision which contains the git commit id and a
> Implementation-Branch which contains the branch.
> >>>
> >>> We should add these to all of our jira issues so developers can easily
> figure out the revision being tested and work appropriately.
> >>>
> >>> I will also cherry-pick this to 4.2. I assume there's no objections.
> >>>
> >>> --Alex
> >>>
> >
Re: Adding git commit ids to our packaging...
Posted by Chip Childers <ch...@sungard.com>.
Cool. +1 then
On Jul 11, 2013, at 9:28 PM, David Nalley <da...@gnsa.us> wrote:
> I was worried about the same thing, but ran build_asf.sh to create a
> tarball and then built it.
>
> Here's the resulting output, which isn't perfectly nice, but also isn't broken.
>
> ke4qqq@mba ~/apache-cloudstack-4.2.0-RC2-src/client/target/META-INF[master*]$
> cat MANIFEST.MF
> Manifest-Version: 1.0
> Implementation-Vendor: The Apache Software Foundation
> Implementation-Title: Apache CloudStack Client UI
> Implementation-Version: 4.2.0-RC2
> Implementation-Revision: UNKNOWN_REVISION
> Implementation-Vendor-Id: org.apache.cloudstack
> Built-By: ke4qqq
> Build-Jdk: 1.7.0_09-icedtea
> Created-By: Apache Maven 3.0.4
> Implementation-Branch: UNKNOWN_BRANCH
> Archiver-Version: Plexus Archiver
>
> --David
>
> On Thu, Jul 11, 2013 at 9:01 PM, Chip Childers
> <ch...@sungard.com> wrote:
>> Is it off by default?
>>
>> Our releases aren't from git.
>>
>> On Jul 11, 2013, at 8:38 PM, Alex Huang <Al...@citrix.com> wrote:
>>
>>> Hi All,
>>>
>>> I added the branch and git commit id to the war file. You can find it by opening the war file and retrieving the META-INF/MANIFEST.MF. Inside, there is a Implementation-Revision which contains the git commit id and a Implementation-Branch which contains the branch.
>>>
>>> We should add these to all of our jira issues so developers can easily figure out the revision being tested and work appropriately.
>>>
>>> I will also cherry-pick this to 4.2. I assume there's no objections.
>>>
>>> --Alex
>>>
>
Re: Adding git commit ids to our packaging...
Posted by David Nalley <da...@gnsa.us>.
I was worried about the same thing, but ran build_asf.sh to create a
tarball and then built it.
Here's the resulting output, which isn't perfectly nice, but also isn't broken.
ke4qqq@mba ~/apache-cloudstack-4.2.0-RC2-src/client/target/META-INF[master*]$
cat MANIFEST.MF
Manifest-Version: 1.0
Implementation-Vendor: The Apache Software Foundation
Implementation-Title: Apache CloudStack Client UI
Implementation-Version: 4.2.0-RC2
Implementation-Revision: UNKNOWN_REVISION
Implementation-Vendor-Id: org.apache.cloudstack
Built-By: ke4qqq
Build-Jdk: 1.7.0_09-icedtea
Created-By: Apache Maven 3.0.4
Implementation-Branch: UNKNOWN_BRANCH
Archiver-Version: Plexus Archiver
--David
On Thu, Jul 11, 2013 at 9:01 PM, Chip Childers
<ch...@sungard.com> wrote:
> Is it off by default?
>
> Our releases aren't from git.
>
> On Jul 11, 2013, at 8:38 PM, Alex Huang <Al...@citrix.com> wrote:
>
>> Hi All,
>>
>> I added the branch and git commit id to the war file. You can find it by opening the war file and retrieving the META-INF/MANIFEST.MF. Inside, there is a Implementation-Revision which contains the git commit id and a Implementation-Branch which contains the branch.
>>
>> We should add these to all of our jira issues so developers can easily figure out the revision being tested and work appropriately.
>>
>> I will also cherry-pick this to 4.2. I assume there's no objections.
>>
>> --Alex
>>
Re: Adding git commit ids to our packaging...
Posted by Chip Childers <ch...@sungard.com>.
Is it off by default?
Our releases aren't from git.
On Jul 11, 2013, at 8:38 PM, Alex Huang <Al...@citrix.com> wrote:
> Hi All,
>
> I added the branch and git commit id to the war file. You can find it by opening the war file and retrieving the META-INF/MANIFEST.MF. Inside, there is a Implementation-Revision which contains the git commit id and a Implementation-Branch which contains the branch.
>
> We should add these to all of our jira issues so developers can easily figure out the revision being tested and work appropriately.
>
> I will also cherry-pick this to 4.2. I assume there's no objections.
>
> --Alex
>
Re: Adding git commit ids to our packaging...
Posted by Kelven Yang <ke...@citrix.com>.
+10000
On 7/11/13 5:36 PM, "Alex Huang" <Al...@citrix.com> wrote:
>Hi All,
>
>I added the branch and git commit id to the war file. You can find it by
>opening the war file and retrieving the META-INF/MANIFEST.MF. Inside,
>there is a Implementation-Revision which contains the git commit id and a
>Implementation-Branch which contains the branch.
>
>We should add these to all of our jira issues so developers can easily
>figure out the revision being tested and work appropriately.
>
>I will also cherry-pick this to 4.2. I assume there's no objections.
>
>--Alex