[I] Shuffle spilled_bytes metric is incorrect [datafusion-comet]

["andygrove (via GitHub)" <gi...@apache.org>]

andygrove opened a new issue, #1437:
URL: https://github.com/apache/datafusion-comet/issues/1437

   ### Describe the bug
   
   In `ShuffleWriterExec`, we are writing incorrect data for `spilled_bytes`. We are adding the size of the current memory reservation rather than the number of bytes written to the shuffle file.
   
   ```rust
           let offsets = spill_into(
               &mut self.buffered_partitions,
               spillfile.path(),
               self.num_output_partitions,
               &self.metrics,
           )?;
   
           let mut spills = self.spills.lock().await;
           let used = self.reservation.size();
           self.metrics.spill_count.add(1);
           self.metrics.spilled_bytes.add(used);
   
   ```
   
   ### Steps to reproduce
   
   _No response_
   
   ### Expected behavior
   
   _No response_
   
   ### Additional context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [I] Shuffle spilled_bytes metric is incorrect [datafusion-comet]

["andygrove (via GitHub)" <gi...@apache.org>]

andygrove closed issue #1437: Shuffle spilled_bytes metric is incorrect
URL: https://github.com/apache/datafusion-comet/issues/1437


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org