You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-dev@hadoop.apache.org by "Allen Wittenauer (JIRA)" <ji...@apache.org> on 2014/07/17 19:49:05 UTC

[jira] [Resolved] (HDFS-261) Side classes should be moved to separate files

     [ https://issues.apache.org/jira/browse/HDFS-261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Allen Wittenauer resolved HDFS-261.
-----------------------------------

    Resolution: Incomplete

Given the number of changes in source code layout, the switch to maven, etc, I'm going to close this out as stale.

> Side classes should be moved to separate files
> ----------------------------------------------
>
>                 Key: HDFS-261
>                 URL: https://issues.apache.org/jira/browse/HDFS-261
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>         Attachments: HADOOP-1826-BlockCrcUpgrade.ingnorespace.patch, HADOOP-1826-BlockCrcUpgrade.patch
>
>
> The following classes are "side" classes that aren't in files with the same name. This caused problems last night because ant compiled things in the wrong order and couldn't find one of the relevant classes. I think it would make the code easier to read and understand if you could always find a given class in the expected place.
> {code}
> > find src/java -name '*.java' | xargs grep '^class' | sed -e 's|\([a-zA-Z0-9/]*/\)\([^/.]*\)[.]java:class \([^ <]*\).*|\1 \2 \3|' | awk '{if ($2 != $3) print $1$2".java",$3}'
> src/java/org/apache/hadoop/mapred/BasicTypeSorterBase.java MRSortResultIterator
> src/java/org/apache/hadoop/dfs/BlockCommand.java DatanodeCommand
> src/java/org/apache/hadoop/dfs/Storage.java StorageInfo
> src/java/org/apache/hadoop/dfs/BlockCrcUpgrade.java BlockCrcInfo
> src/java/org/apache/hadoop/dfs/BlockCrcUpgrade.java DNBlockUpgradeInfo
> src/java/org/apache/hadoop/dfs/BlockCrcUpgrade.java BlockCrcUpgradeUtils
> src/java/org/apache/hadoop/dfs/BlockCrcUpgrade.java BlockCrcUpgradeObjectDatanode
> src/java/org/apache/hadoop/dfs/BlockCrcUpgrade.java BlockCrcUpgradeObjectNamenode
> src/java/org/apache/hadoop/dfs/INode.java INodeDirectory
> src/java/org/apache/hadoop/dfs/INode.java INodeFile
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)