[jira] [Commented] (CALCITE-4251) Overload RelMetadataQuery#getColumnOrigin method

["Julian Hyde (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-4251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17206815#comment-17206815 ] 

Julian Hyde commented on CALCITE-4251:
--------------------------------------

I reviewed the PR. The javadoc needs work: e.g. duplicate param, incorrect description of behavior if called with derived=false. The first line of the javadoc should describe exactly what the method does.

Consider changing derived's type from boolean to Boolean, so that people can call with 'don't care'.

Change the summary of this Jira case so people know it's about whether the origin is derived.

> Overload RelMetadataQuery#getColumnOrigin method
> ------------------------------------------------
>
>                 Key: CALCITE-4251
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4251
>             Project: Calcite
>          Issue Type: Wish
>            Reporter: xzh_dz
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> A case:
>  
> {code:java}
> final String sql1 = ""
>     + "select empno, sum(sal) as all_sal\n"
>     + "from emp\n"
>     + "group by empno";
> {code}
> When i try to get the `all_sal` origin column field,it will return null and it is derived. we always get the origin column although it is derived. We should overload this method.
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)