You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zookeeper.apache.org by "Benjamin Reed (Updated) (JIRA)" <ji...@apache.org> on 2012/02/10 06:15:59 UTC

[jira] [Updated] (ZOOKEEPER-1390) some expensive debug code not protected by a check for debug

     [ https://issues.apache.org/jira/browse/ZOOKEEPER-1390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Benjamin Reed updated ZOOKEEPER-1390:
-------------------------------------

    Attachment: ZOOKEEPER-1390.patch

this fixes the performance issue. i found that the improvement is anywhere from 5% (with 100% reads) to almost 100% (with 100% writes and 3 servers)

no tests since this is not a bug fix and does not add functionality.
                
> some expensive debug code not protected by a check for debug
> ------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1390
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1390
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: server
>            Reporter: Benjamin Reed
>             Fix For: 3.5.0
>
>         Attachments: ZOOKEEPER-1390.patch
>
>
> there is some expensive debug code in DataTree.processTxn() that formats transactions for debugging that are very expensive but are only used when errors happen and when debugging is turned on.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira