You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Ashish Singh <as...@cloudera.com> on 2015/07/15 20:22:05 UTC
Re: [jira] [Created] (KAFKA-1944) Rename LogCleaner and related
classes to LogCompactor
Makes sense!
On Wednesday, July 15, 2015, Joel Koshy (JIRA) <ji...@apache.org> wrote:
>
> [
> https://issues.apache.org/jira/browse/KAFKA-1944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14628432#comment-14628432
> ]
>
> Joel Koshy commented on KAFKA-1944:
> -----------------------------------
>
> Perhaps KIP would be overkill for this. I would recommend just keeping the
> old config name and add the new config. If the user specifies the old
> config emit a warning that it will be deprecated.
>
> > Rename LogCleaner and related classes to LogCompactor
> > -----------------------------------------------------
> >
> > Key: KAFKA-1944
> > URL: https://issues.apache.org/jira/browse/KAFKA-1944
> > Project: Kafka
> > Issue Type: Bug
> > Reporter: Gwen Shapira
> > Assignee: Aravind Selvan
> > Labels: newbie
> >
> > Following a mailing list discussion:
> > "the name LogCleaner is seriously misleading. Its more of a log
> compactor.
> > Deleting old logs happens elsewhere from what I've seen."
> > Note that this may require renaming related classes, objects, configs
> and metrics.
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.3.4#6332)
>
--
Ashish 🎤h