You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Guangya Liu <gy...@gmail.com> on 2015/08/08 18:23:28 UTC

Review Request 37257: Add SUPPRESS call interface to the scheduler

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37257/
-----------------------------------------------------------

Review request for mesos.


Repository: mesos


Description
-------

This is just part of MESOS-3037, this patch only add the interface
of SUPPRESS call.


Diffs
-----

  include/mesos/scheduler.hpp cd235a11e63a5df742057be8e2dddd7629db4cf9 
  include/mesos/scheduler/scheduler.proto 89daf8a6b74057ee156b3ad691397e76fcb835b8 
  src/sched/sched.cpp 012af0508eeceeccd168b29f36fa258d20b28c21 
  src/tests/scheduler_tests.cpp 9d29d1ab0cb2914f4749e05af95c1c21e88908ca 

Diff: https://reviews.apache.org/r/37257/diff/


Testing
-------


Thanks,

Guangya Liu

Re: Review Request 37257: Add SUPPRESS call interface to the scheduler

Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37257/#review94637
-----------------------------------------------------------


Consider sending an optional timeout with the SUPPRESS message. This makes it more consistent with declining offers and allows frameorks to avoid sending an explicit revive.

- James Peach


On Aug. 8, 2015, 4:25 p.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37257/
> -----------------------------------------------------------
> 
> (Updated Aug. 8, 2015, 4:25 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-3037
>     https://issues.apache.org/jira/browse/MESOS-3037
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is just part of MESOS-3037, this patch only add the interface
> of SUPPRESS call.
> 
> 
> Diffs
> -----
> 
>   include/mesos/scheduler.hpp cd235a11e63a5df742057be8e2dddd7629db4cf9 
>   include/mesos/scheduler/scheduler.proto 89daf8a6b74057ee156b3ad691397e76fcb835b8 
>   src/sched/sched.cpp 012af0508eeceeccd168b29f36fa258d20b28c21 
>   src/tests/scheduler_tests.cpp 9d29d1ab0cb2914f4749e05af95c1c21e88908ca 
> 
> Diff: https://reviews.apache.org/r/37257/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 37257: Add SUPPRESS call interface to the scheduler

Posted by haosdent huang <ha...@gmail.com>.

> On Aug. 13, 2015, 11:39 p.m., Mesos ReviewBot wrote:
> > Bad patch!
> > 
> > Reviews applied: [37257]
> > 
> > Failed command: ./support/apply-review.sh -n -r 37257
> > 
> > Error:
> >  2015-08-13 23:39:06 URL:https://reviews.apache.org/r/37257/diff/raw/ [5394/5394] -> "37257.patch" [1]
> > error: patch failed: src/tests/scheduler_tests.cpp:903
> > error: src/tests/scheduler_tests.cpp: patch does not apply
> > Failed to apply patch

Hi, you need rebase from current master code.


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37257/#review95351
-----------------------------------------------------------


On Aug. 13, 2015, 7:44 p.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37257/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2015, 7:44 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3037
>     https://issues.apache.org/jira/browse/MESOS-3037
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is just part of MESOS-3037, this patch only add the interface
> of SUPPRESS call.
> 
> 
> Diffs
> -----
> 
>   include/mesos/scheduler.hpp cd235a11e63a5df742057be8e2dddd7629db4cf9 
>   include/mesos/scheduler/scheduler.proto 89daf8a6b74057ee156b3ad691397e76fcb835b8 
>   src/sched/sched.cpp 012af0508eeceeccd168b29f36fa258d20b28c21 
>   src/tests/scheduler_tests.cpp 9d29d1ab0cb2914f4749e05af95c1c21e88908ca 
> 
> Diff: https://reviews.apache.org/r/37257/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 37257: Add SUPPRESS call interface to the scheduler

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37257/#review95351
-----------------------------------------------------------


Bad patch!

Reviews applied: [37257]

Failed command: ./support/apply-review.sh -n -r 37257

Error:
 2015-08-13 23:39:06 URL:https://reviews.apache.org/r/37257/diff/raw/ [5394/5394] -> "37257.patch" [1]
error: patch failed: src/tests/scheduler_tests.cpp:903
error: src/tests/scheduler_tests.cpp: patch does not apply
Failed to apply patch

- Mesos ReviewBot


On Aug. 13, 2015, 7:44 p.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37257/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2015, 7:44 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3037
>     https://issues.apache.org/jira/browse/MESOS-3037
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is just part of MESOS-3037, this patch only add the interface
> of SUPPRESS call.
> 
> 
> Diffs
> -----
> 
>   include/mesos/scheduler.hpp cd235a11e63a5df742057be8e2dddd7629db4cf9 
>   include/mesos/scheduler/scheduler.proto 89daf8a6b74057ee156b3ad691397e76fcb835b8 
>   src/sched/sched.cpp 012af0508eeceeccd168b29f36fa258d20b28c21 
>   src/tests/scheduler_tests.cpp 9d29d1ab0cb2914f4749e05af95c1c21e88908ca 
> 
> Diff: https://reviews.apache.org/r/37257/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 37257: Add SUPPRESS call interface to the scheduler

Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37257/
-----------------------------------------------------------

(Updated 八月 13, 2015, 7:44 p.m.)


Review request for mesos and Vinod Kone.


Bugs: MESOS-3037
    https://issues.apache.org/jira/browse/MESOS-3037


Repository: mesos


Description
-------

This is just part of MESOS-3037, this patch only add the interface
of SUPPRESS call.


Diffs (updated)
-----

  include/mesos/scheduler.hpp cd235a11e63a5df742057be8e2dddd7629db4cf9 
  include/mesos/scheduler/scheduler.proto 89daf8a6b74057ee156b3ad691397e76fcb835b8 
  src/sched/sched.cpp 012af0508eeceeccd168b29f36fa258d20b28c21 
  src/tests/scheduler_tests.cpp 9d29d1ab0cb2914f4749e05af95c1c21e88908ca 

Diff: https://reviews.apache.org/r/37257/diff/


Testing
-------


Thanks,

Guangya Liu

Re: Review Request 37257: Add SUPPRESS call interface to the scheduler

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37257/#review94638
-----------------------------------------------------------


Patch looks great!

Reviews applied: [37257]

All tests passed.

- Mesos ReviewBot


On Aug. 8, 2015, 4:25 p.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37257/
> -----------------------------------------------------------
> 
> (Updated Aug. 8, 2015, 4:25 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-3037
>     https://issues.apache.org/jira/browse/MESOS-3037
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is just part of MESOS-3037, this patch only add the interface
> of SUPPRESS call.
> 
> 
> Diffs
> -----
> 
>   include/mesos/scheduler.hpp cd235a11e63a5df742057be8e2dddd7629db4cf9 
>   include/mesos/scheduler/scheduler.proto 89daf8a6b74057ee156b3ad691397e76fcb835b8 
>   src/sched/sched.cpp 012af0508eeceeccd168b29f36fa258d20b28c21 
>   src/tests/scheduler_tests.cpp 9d29d1ab0cb2914f4749e05af95c1c21e88908ca 
> 
> Diff: https://reviews.apache.org/r/37257/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 37257: Add SUPPRESS call interface to the scheduler

Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37257/
-----------------------------------------------------------

(Updated 八月 8, 2015, 4:25 p.m.)


Review request for mesos.


Bugs: MESOS-3037
    https://issues.apache.org/jira/browse/MESOS-3037


Repository: mesos


Description
-------

This is just part of MESOS-3037, this patch only add the interface
of SUPPRESS call.


Diffs
-----

  include/mesos/scheduler.hpp cd235a11e63a5df742057be8e2dddd7629db4cf9 
  include/mesos/scheduler/scheduler.proto 89daf8a6b74057ee156b3ad691397e76fcb835b8 
  src/sched/sched.cpp 012af0508eeceeccd168b29f36fa258d20b28c21 
  src/tests/scheduler_tests.cpp 9d29d1ab0cb2914f4749e05af95c1c21e88908ca 

Diff: https://reviews.apache.org/r/37257/diff/


Testing
-------


Thanks,

Guangya Liu