You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@seata.apache.org by "slievrly (via GitHub)" <gi...@apache.org> on 2024/01/25 11:39:07 UTC
[PR] optimize: add io.seata package shade [incubator-seata]
slievrly opened a new pull request, #6302:
URL: https://github.com/apache/incubator-seata/pull/6302
<!-- Please make sure you have read and understood the contributing guidelines -->
- [ ] I have registered the PR [changes](../changes).
### Ⅰ. Describe what this PR did
add io.seata package shade
### Ⅱ. Does this pull request fix one issue?
<!-- If that, add "fixes #xxx" below in the next line, for example, fixes #97. -->
### Ⅲ. Why don't you add test cases (unit test/integration test)?
### Ⅳ. Describe how to verify it
### Ⅴ. Special notes for reviews
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize: add io.seata package shade [incubator-seata]
Posted by "funky-eyes (via GitHub)" <gi...@apache.org>.
funky-eyes commented on code in PR #6302:
URL: https://github.com/apache/incubator-seata/pull/6302#discussion_r1466285066
##########
compatible/pom.xml:
##########
@@ -30,7 +30,7 @@
<dependencies>
<dependency>
- <groupId>${project.groupId}</groupId>
+ <groupId>org.apache.seata</groupId>
Review Comment:
In my judgment, if the compatible module doesn't depend on org.apache.seata:seata-all, then it's not complete and users will have problems using it because of the missing classes. If he's missing classes, what's the difference between that and just using io.seata:seata-all and typing a version specifically to be used as a usedby tag?
根据我的判断，如果兼容模块不依赖于org. apache.seata：seata-all，那么它就不完整，用户会因为缺少类而在使用它时遇到问题。如果他缺少类，这与仅使用io.seata：seata-all并输入专门用作usedby标记的版本有什么区别？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize: add io.seata package shade [incubator-seata]
Posted by "funky-eyes (via GitHub)" <gi...@apache.org>.
funky-eyes commented on code in PR #6302:
URL: https://github.com/apache/incubator-seata/pull/6302#discussion_r1466277753
##########
compatible/pom.xml:
##########
@@ -30,7 +30,7 @@
<dependencies>
<dependency>
- <groupId>${project.groupId}</groupId>
+ <groupId>org.apache.seata</groupId>
Review Comment:
如果他不依赖org.apache.seata:seata-all,会影响应用使用吗?假设我使用一个io.seata:seata-all 2.1.0-SNAPSHOT
If he doesn't depend on org.apache.seata:seata-all, will it affect the application usage? Let's say I use an io.seata:seata-all 2.1.0-SNAPSHOT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize: add io.seata package shade [incubator-seata]
Posted by "funky-eyes (via GitHub)" <gi...@apache.org>.
funky-eyes commented on PR #6302:
URL: https://github.com/apache/incubator-seata/pull/6302#issuecomment-1910098769
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize: add io.seata package shade [incubator-seata]
Posted by "slievrly (via GitHub)" <gi...@apache.org>.
slievrly commented on code in PR #6302:
URL: https://github.com/apache/incubator-seata/pull/6302#discussion_r1475481470
##########
compatible/pom.xml:
##########
@@ -30,7 +30,7 @@
<dependencies>
<dependency>
- <groupId>${project.groupId}</groupId>
+ <groupId>org.apache.seata</groupId>
Review Comment:
io.seata:seata-all won't release module package.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize: add io.seata package shade [incubator-seata]
Posted by "funky-eyes (via GitHub)" <gi...@apache.org>.
funky-eyes merged PR #6302:
URL: https://github.com/apache/incubator-seata/pull/6302
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize: add io.seata package shade [incubator-seata]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #6302:
URL: https://github.com/apache/incubator-seata/pull/6302#issuecomment-1910018605
## [Codecov](https://app.codecov.io/gh/apache/incubator-seata/pull/6302?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Comparison is base [(`80482ee`)](https://app.codecov.io/gh/apache/incubator-seata/commit/80482ee9db05766b207f2d33270aeb78686c5a77?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 30.08% compared to head [(`4c1b92a`)](https://app.codecov.io/gh/apache/incubator-seata/pull/6302?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 30.09%.
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/incubator-seata/pull/6302?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## 2.x #6302 +/- ##
=========================================
Coverage 30.08% 30.09%
+ Complexity 5436 5435 -1
=========================================
Files 930 930
Lines 60222 60222
Branches 7121 7121
=========================================
+ Hits 18119 18125 +6
+ Misses 40209 40200 -9
- Partials 1894 1897 +3
```
[see 3 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-seata/pull/6302/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize: add io.seata package shade [incubator-seata]
Posted by "funky-eyes (via GitHub)" <gi...@apache.org>.
funky-eyes commented on code in PR #6302:
URL: https://github.com/apache/incubator-seata/pull/6302#discussion_r1466285066
##########
compatible/pom.xml:
##########
@@ -30,7 +30,7 @@
<dependencies>
<dependency>
- <groupId>${project.groupId}</groupId>
+ <groupId>org.apache.seata</groupId>
Review Comment:
In my judgment, if the compatible module doesn't depend on org.apache.seata:seata-all, then it's not complete and users will have problems using it because of the missing classes. If he's missing classes, what's the difference between that and just using io.seata:seata-all and typing a version specifically to be used as a usedby tag?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize: add io.seata package shade [incubator-seata]
Posted by "funky-eyes (via GitHub)" <gi...@apache.org>.
funky-eyes commented on code in PR #6302:
URL: https://github.com/apache/incubator-seata/pull/6302#discussion_r1466313915
##########
compatible/pom.xml:
##########
@@ -30,7 +30,7 @@
Review Comment:
```suggestion
<properties>
<maven.compiler.source>8</maven.compiler.source>
<maven.compiler.target>8</maven.compiler.target>
</properties>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org