You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by jo...@apache.org on 2018/07/05 07:40:48 UTC

zeppelin git commit: Minor fix "ipykernel" package name shown in logs when ipython prerequisite isn't met

Repository: zeppelin
Updated Branches:
  refs/heads/master 36f7d3da7 -> afd658d3d


Minor fix "ipykernel" package name shown in logs when ipython prerequisite isn't met

### What is this PR for?
minor fix to show correct package name `ipykernel` in logs when prerequisite for ipython interpreter isn't met.

### What type of PR is it?
[ Improvement ]

### Todos
* [x] - fix naming

### What is the Jira issue?
* Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/
* Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg. [ZEPPELIN-533]

### How should this be tested?
if `ipykernel` isn't installed then it would show correct message in logs when running ipython interpreter

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update?
* Is there breaking changes for older versions?
* Does this needs documentation?

Author: Khalid Huseynov <kh...@gmail.com>

Closes #3046 from khalidhuseynov/fix/ipykernel-msg and squashes the following commits:

7a3b124f9 [Khalid Huseynov] fix minor
b6a3d5c5f [Khalid Huseynov] fix package name shown to user when not installed


Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/afd658d3
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/afd658d3
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/afd658d3

Branch: refs/heads/master
Commit: afd658d3d08843f9667b64abbc30626d9ba23f35
Parents: 36f7d3d
Author: Khalid Huseynov <kh...@gmail.com>
Authored: Mon Jul 2 11:08:52 2018 +0900
Committer: Jongyoul Lee <jo...@apache.org>
Committed: Thu Jul 5 16:40:45 2018 +0900

----------------------------------------------------------------------
 .../main/java/org/apache/zeppelin/python/IPythonInterpreter.java | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/zeppelin/blob/afd658d3/python/src/main/java/org/apache/zeppelin/python/IPythonInterpreter.java
----------------------------------------------------------------------
diff --git a/python/src/main/java/org/apache/zeppelin/python/IPythonInterpreter.java b/python/src/main/java/org/apache/zeppelin/python/IPythonInterpreter.java
index 8c7e8ad..2d3c817 100644
--- a/python/src/main/java/org/apache/zeppelin/python/IPythonInterpreter.java
+++ b/python/src/main/java/org/apache/zeppelin/python/IPythonInterpreter.java
@@ -178,7 +178,7 @@ public class IPythonInterpreter extends Interpreter implements ExecuteResultHand
         return "jupyter-client is not installed.";
       }
       if (!freezeOutput.contains("ipykernel=")) {
-        return "ipkernel is not installed";
+        return "ipykernel is not installed";
       }
       if (!freezeOutput.contains("ipython=")) {
         return "ipython is not installed";
@@ -186,7 +186,7 @@ public class IPythonInterpreter extends Interpreter implements ExecuteResultHand
       if (!freezeOutput.contains("grpcio=")) {
         return "grpcio is not installed";
       }
-      LOGGER.info("IPython prerequisite is meet");
+      LOGGER.info("IPython prerequisite is met");
     } catch (Exception e) {
       LOGGER.warn("Fail to checkIPythonPrerequisite", e);
       return "Fail to checkIPythonPrerequisite: " + ExceptionUtils.getStackTrace(e);