[GitHub] [iceberg] deepyaman commented on a diff in pull request #7248: Python: Use Prettier to format TOML and more files

["deepyaman (via GitHub)" <gi...@apache.org>]

deepyaman commented on code in PR #7248:
URL: https://github.com/apache/iceberg/pull/7248#discussion_r1154386270


##########
python/mkdocs/docs/api.md:
##########
@@ -307,15 +307,18 @@ scan = table.scan(
 The low level API `plan_files` methods returns a set of tasks that provide the files that might contain matching rows:
 
 ```json
-['s3a://warehouse/wh/nyc/taxis/data/00003-4-42464649-92dd-41ad-b83b-dea1a2fe4b58-00001.parquet']
+[
+  "s3a://warehouse/wh/nyc/taxis/data/00003-4-42464649-92dd-41ad-b83b-dea1a2fe4b58-00001.parquet"
+]
 ```
 
 In this case it is up to the engine itself to filter the file itself. Below, `to_arrow()` and `to_duckdb()` that already do this for you.
 
 ### Apache Arrow
 
 !!! note "Requirements"
-    This requires [PyArrow to be installed](index.md)
+
+This requires [PyArrow to be installed](index.md)

Review Comment:
   Hmm... I haven't used `mkdocs` previously, but it seems like their admonition syntax isn't supported by Prettier (or the underlying parser). There are a number of existing issues (e.g. https://github.com/prettier/prettier/issues/3362 and https://github.com/prettier/prettier/issues/12985) highlighting this, and the recommendation seems to wrap them in `<!-- prettier-ignore-start -->`, `<!-- prettier-ignore-end -->`. I can do that if it's acceptable?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org