You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Colm O hEigeartaigh <co...@apache.org> on 2017/03/09 14:42:10 UTC

Re: Review Request 56912: Enabling Ranger HDFS Plugins failed when hadoop program and Ranger HDFS Plugin are not in the same path.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56912/#review168453
-----------------------------------------------------------



Please remove the 'space' before COMPONENT_INSTALL_DIR_NAME.

- Colm O hEigeartaigh


On Feb. 28, 2017, 8:39 a.m., Qiang Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56912/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2017, 8:39 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1400
>     https://issues.apache.org/jira/browse/RANGER-1400
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Enabling Ranger HDFS Plugins failed when hadoop program and Ranger HDFS Plugin are not in the same path.
> 1. Install hadoop-2.7.3 under /var/local/hadoop
> 2. Copy ranger-1.0.0-SNAPSHOT-hdfs-plugin.tar.gz to /usr/local
> 3. Run command: cd /usr/local
> 4. Run command: sudo tar -zxvf ranger-1.0.0-SNAPSHOT-hdfs-plugin.tar.gz
> 5. Modified install.properties according to installation guide.
> 6. Execute enable-hdfs-plugin.sh
> result:
> ERROR: Unable to find the lib directory of component [hadoop]; dir [/usr/local/hadoop/lib] not found.
> 
> Reason:
> COMPONENT_INSTALL_DIR_NAME does not exist in install.properties. So the HCOMPONENT_INSTALL_DIR_NAME variable is empty when execute the following sentence.
> HCOMPONENT_INSTALL_DIR_NAME=$(getInstallProperty 'COMPONENT_INSTALL_DIR_NAME')
> The result is that HCOMPONENT_LIB_DIR directory doesn't exist.
> 
> We should add COMPONENT_INSTALL_DIR_NAME parameter to install.properties. The error can be avoided after setting COMPONENT_INSTALL_DIR_NAME.
> 
> Test and verify:
> I carefully tested and verified the patch before commit the issue.
> 
> 
> Diffs
> -----
> 
>   hdfs-agent/scripts/install.properties 148d2ba 
> 
> 
> Diff: https://reviews.apache.org/r/56912/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qiang Zhang
> 
>


Re: Review Request 56912: Enabling Ranger HDFS Plugins failed when hadoop program and Ranger HDFS Plugin are not in the same path.

Posted by Colm O hEigeartaigh <co...@apache.org>.

> On March 9, 2017, 2:42 p.m., Colm O hEigeartaigh wrote:
> > Please remove the 'space' before COMPONENT_INSTALL_DIR_NAME.
> 
> Qiang Zhang wrote:
>     Ok. I have removed the space before COMPONENT_INSTALL_DIR_NAME and updated the patch. Thanks.

The comment is > 80 characters which means it wraps on a standard terminal window. Could you split it over two lines?


- Colm


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56912/#review168453
-----------------------------------------------------------


On March 10, 2017, 2:44 a.m., Qiang Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56912/
> -----------------------------------------------------------
> 
> (Updated March 10, 2017, 2:44 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1400
>     https://issues.apache.org/jira/browse/RANGER-1400
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Enabling Ranger HDFS Plugins failed when hadoop program and Ranger HDFS Plugin are not in the same path.
> 1. Install hadoop-2.7.3 under /var/local/hadoop
> 2. Copy ranger-1.0.0-SNAPSHOT-hdfs-plugin.tar.gz to /usr/local
> 3. Run command: cd /usr/local
> 4. Run command: sudo tar -zxvf ranger-1.0.0-SNAPSHOT-hdfs-plugin.tar.gz
> 5. Modified install.properties according to installation guide.
> 6. Execute enable-hdfs-plugin.sh
> result:
> ERROR: Unable to find the lib directory of component [hadoop]; dir [/usr/local/hadoop/lib] not found.
> 
> Reason:
> COMPONENT_INSTALL_DIR_NAME does not exist in install.properties. So the HCOMPONENT_INSTALL_DIR_NAME variable is empty when execute the following sentence.
> HCOMPONENT_INSTALL_DIR_NAME=$(getInstallProperty 'COMPONENT_INSTALL_DIR_NAME')
> The result is that HCOMPONENT_LIB_DIR directory doesn't exist.
> 
> We should add COMPONENT_INSTALL_DIR_NAME parameter to install.properties. The error can be avoided after setting COMPONENT_INSTALL_DIR_NAME.
> 
> Test and verify:
> I carefully tested and verified the patch before commit the issue.
> 
> 
> Diffs
> -----
> 
>   hdfs-agent/scripts/install.properties 1d54025 
> 
> 
> Diff: https://reviews.apache.org/r/56912/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qiang Zhang
> 
>


Re: Review Request 56912: Enabling Ranger HDFS Plugins failed when hadoop program and Ranger HDFS Plugin are not in the same path.

Posted by Qiang Zhang <zh...@zte.com.cn>.

> On March 9, 2017, 2:42 p.m., Colm O hEigeartaigh wrote:
> > Please remove the 'space' before COMPONENT_INSTALL_DIR_NAME.
> 
> Qiang Zhang wrote:
>     Ok. I have removed the space before COMPONENT_INSTALL_DIR_NAME and updated the patch. Thanks.
> 
> Colm O hEigeartaigh wrote:
>     The comment is > 80 characters which means it wraps on a standard terminal window. Could you split it over two lines?

Ok. I haved modified and updated the patch.


- Qiang


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56912/#review168453
-----------------------------------------------------------


On March 11, 2017, 6:23 a.m., Qiang Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56912/
> -----------------------------------------------------------
> 
> (Updated March 11, 2017, 6:23 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1400
>     https://issues.apache.org/jira/browse/RANGER-1400
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Enabling Ranger HDFS Plugins failed when hadoop program and Ranger HDFS Plugin are not in the same path.
> 1. Install hadoop-2.7.3 under /var/local/hadoop
> 2. Copy ranger-1.0.0-SNAPSHOT-hdfs-plugin.tar.gz to /usr/local
> 3. Run command: cd /usr/local
> 4. Run command: sudo tar -zxvf ranger-1.0.0-SNAPSHOT-hdfs-plugin.tar.gz
> 5. Modified install.properties according to installation guide.
> 6. Execute enable-hdfs-plugin.sh
> result:
> ERROR: Unable to find the lib directory of component [hadoop]; dir [/usr/local/hadoop/lib] not found.
> 
> Reason:
> COMPONENT_INSTALL_DIR_NAME does not exist in install.properties. So the HCOMPONENT_INSTALL_DIR_NAME variable is empty when execute the following sentence.
> HCOMPONENT_INSTALL_DIR_NAME=$(getInstallProperty 'COMPONENT_INSTALL_DIR_NAME')
> The result is that HCOMPONENT_LIB_DIR directory doesn't exist.
> 
> We should add COMPONENT_INSTALL_DIR_NAME parameter to install.properties. The error can be avoided after setting COMPONENT_INSTALL_DIR_NAME.
> 
> Test and verify:
> I carefully tested and verified the patch before commit the issue.
> 
> 
> Diffs
> -----
> 
>   hdfs-agent/scripts/install.properties 1d54025 
> 
> 
> Diff: https://reviews.apache.org/r/56912/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qiang Zhang
> 
>


Re: Review Request 56912: Enabling Ranger HDFS Plugins failed when hadoop program and Ranger HDFS Plugin are not in the same path.

Posted by Qiang Zhang <zh...@zte.com.cn>.

> On March 9, 2017, 2:42 p.m., Colm O hEigeartaigh wrote:
> > Please remove the 'space' before COMPONENT_INSTALL_DIR_NAME.

Ok. I have removed the space before COMPONENT_INSTALL_DIR_NAME and updated the patch. Thanks.


- Qiang


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56912/#review168453
-----------------------------------------------------------


On March 10, 2017, 2:44 a.m., Qiang Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56912/
> -----------------------------------------------------------
> 
> (Updated March 10, 2017, 2:44 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1400
>     https://issues.apache.org/jira/browse/RANGER-1400
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Enabling Ranger HDFS Plugins failed when hadoop program and Ranger HDFS Plugin are not in the same path.
> 1. Install hadoop-2.7.3 under /var/local/hadoop
> 2. Copy ranger-1.0.0-SNAPSHOT-hdfs-plugin.tar.gz to /usr/local
> 3. Run command: cd /usr/local
> 4. Run command: sudo tar -zxvf ranger-1.0.0-SNAPSHOT-hdfs-plugin.tar.gz
> 5. Modified install.properties according to installation guide.
> 6. Execute enable-hdfs-plugin.sh
> result:
> ERROR: Unable to find the lib directory of component [hadoop]; dir [/usr/local/hadoop/lib] not found.
> 
> Reason:
> COMPONENT_INSTALL_DIR_NAME does not exist in install.properties. So the HCOMPONENT_INSTALL_DIR_NAME variable is empty when execute the following sentence.
> HCOMPONENT_INSTALL_DIR_NAME=$(getInstallProperty 'COMPONENT_INSTALL_DIR_NAME')
> The result is that HCOMPONENT_LIB_DIR directory doesn't exist.
> 
> We should add COMPONENT_INSTALL_DIR_NAME parameter to install.properties. The error can be avoided after setting COMPONENT_INSTALL_DIR_NAME.
> 
> Test and verify:
> I carefully tested and verified the patch before commit the issue.
> 
> 
> Diffs
> -----
> 
>   hdfs-agent/scripts/install.properties 1d54025 
> 
> 
> Diff: https://reviews.apache.org/r/56912/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qiang Zhang
> 
>