You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@orc.apache.org by GitBox <gi...@apache.org> on 2022/07/18 12:42:15 UTC
[GitHub] [orc] deadwind4 opened a new pull request, #1181: Remove unuseful method in FileDump
deadwind4 opened a new pull request, #1181:
URL: https://github.com/apache/orc/pull/1181
### What changes were proposed in this pull request?
Remove a toString() in `FileDump.java`
### Why are the changes needed?
toString() method is unuseful in FileDump class, so it should be deleted.
### How was this patch tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] deadwind4 commented on pull request #1181: Remove unuseful toString method
Posted by GitBox <gi...@apache.org>.
deadwind4 commented on PR #1181:
URL: https://github.com/apache/orc/pull/1181#issuecomment-1193038647
> Here is a superset of this PR, @deadwind4 . [ORC-1219](https://issues.apache.org/jira/browse/ORC-1219) will be assigned to you because you are the main contributor. Please let me know your Apache JIRA ID.
I have commented on this Jira ticket so that you can assign me. Thanks a lot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #1181: Remove unuseful toString method
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #1181:
URL: https://github.com/apache/orc/pull/1181#issuecomment-1193040687
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on a diff in pull request #1181: Remove unuseful toString method
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on code in PR #1181:
URL: https://github.com/apache/orc/pull/1181#discussion_r927271847
##########
java/tools/src/java/org/apache/orc/tools/FileDump.java:
##########
@@ -103,7 +103,7 @@ public static void main(Configuration conf, String[] args) throws Exception {
rowIndexCols = null; // All the columns
} else {
String[] colStrs = cli.getOptionValue("r").split(",");
- rowIndexCols = new ArrayList<Integer>(colStrs.length);
Review Comment:
The same mistake like https://github.com/apache/orc/pull/1181#discussion_r924633593
##########
java/tools/src/java/org/apache/orc/tools/FileDump.java:
##########
@@ -119,7 +119,7 @@ public static void main(Configuration conf, String[] args) throws Exception {
}
// if the specified path is directory, iterate through all files and print the file dump
- List<String> filesInPath = new ArrayList<>();
Review Comment:
The same mistake like https://github.com/apache/orc/pull/1181#discussion_r924633593
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #1181: Remove unuseful toString method
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #1181:
URL: https://github.com/apache/orc/pull/1181#issuecomment-1192997369
Here is a superset of this PR, @deadwind4 .
ORC-1219 will be assigned to you because you are the main contributor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #1181: Remove unuseful method in FileDump
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #1181:
URL: https://github.com/apache/orc/pull/1181#issuecomment-1191004315
Gentle ping, @deadwind4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on a diff in pull request #1181: Remove unuseful method in FileDump
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on code in PR #1181:
URL: https://github.com/apache/orc/pull/1181#discussion_r923600381
##########
java/tools/src/java/org/apache/orc/tools/FileDump.java:
##########
@@ -755,7 +755,7 @@ private static String getFormattedRowIndices(int col,
ColumnStatisticsImpl.deserialize(colSchema, colStats,
reader.writerUsedProlepticGregorian(),
reader.getConvertToProlepticGregorian());
- buf.append(cs.toString());
+ buf.append(cs);
Review Comment:
Could you try to find more places like this around `tools` or other modules, @deadwind4 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on a diff in pull request #1181: Remove unuseful method in FileDump
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on code in PR #1181:
URL: https://github.com/apache/orc/pull/1181#discussion_r924633593
##########
java/tools/src/java/org/apache/orc/tools/FileDump.java:
##########
@@ -79,7 +79,7 @@ private FileDump() {
}
public static void main(Configuration conf, String[] args) throws Exception {
- List<Integer> rowIndexCols = new ArrayList<Integer>(0);
+ List<Integer> rowIndexCols = new ArrayList<>(0);
Review Comment:
If you want to do this pattern, we had better do this in an independent PR. The current PR title is not proper for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #1181: Remove unuseful toString method
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #1181:
URL: https://github.com/apache/orc/pull/1181#issuecomment-1192745871
Thank you, @deadwind4 . Mostly, the PR looks good.
cc @williamhyun , too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] williamhyun closed pull request #1181: Remove unuseful toString method
Posted by GitBox <gi...@apache.org>.
williamhyun closed pull request #1181: Remove unuseful toString method
URL: https://github.com/apache/orc/pull/1181
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org