[GitHub] [spark] MaxGekk commented on a diff in pull request #41111: [SPARK-39420][SQL] Support `ANALYZE TABLE` on Datasource V2 tables

["MaxGekk (via GitHub)" <gi...@apache.org>]

MaxGekk commented on code in PR #41111:
URL: https://github.com/apache/spark/pull/41111#discussion_r1248727994


##########
core/src/main/resources/error/error-classes.json:
##########
@@ -1973,6 +1973,12 @@
       "The sum of the LIMIT clause and the OFFSET clause must not be greater than the maximum 32-bit integer value (2,147,483,647) but found limit = <limit>, offset = <offset>."
     ]
   },
+  "TABLE_NOT_SUPPORTED_STATISTIC" : {

Review Comment:
   Could you add a sub-class of `UNSUPPORTED_FEATURE`, please.



##########
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala:
##########
@@ -1254,6 +1254,12 @@ private[sql] object QueryExecutionErrors extends QueryErrorsBase {
       messageParameters = Map("o" -> o.toString()))
   }
 
+  def tableNotSupportedStatisticError(tableName: String): SparkIllegalArgumentException = {
+    new SparkIllegalArgumentException(
+      errorClass = "TABLE_NOT_SUPPORTED_STATISTIC",
+      messageParameters = Map("tableName" -> tableName))

Review Comment:
   Wrap `tableName` by `toSQLId`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org