You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Szilard Nemethy <sn...@hortonworks.com> on 2014/11/03 10:48:36 UTC

Re: Review Request 27513: Ambari Server HA Phase 1: Provide backup and restore capability

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27513/
-----------------------------------------------------------

(Updated Nov. 3, 2014, 9:48 a.m.)


Review request for Ambari, Mahadev Konar and Nate Cole.


Changes
-------

Review Request updated with more relevant information


Summary (updated)
-----------------

Ambari Server HA Phase 1: Provide backup and restore capability


Bugs: AMBARI-8068
    https://issues.apache.org/jira/browse/AMBARI-8068


Repository: ambari


Description (updated)
-------

Ambari Server HA Phase 1: Provide backup and restore capability


Diffs
-----

  ambari-agent/conf/unix/ambari-agent e867155 
  ambari-agent/etc/init.d/ambari-agent 898b07e 
  ambari-agent/src/main/python/ambari_agent/main.py 5d33ca4 
  ambari-agent/src/test/python/ambari_agent/TestMain.py 7b1a8c8 
  ambari-server/sbin/ambari-server d4619e9 
  ambari-server/src/main/python/ambari-server.py 0c5174f 
  ambari-server/src/main/python/ambari_server/BackupRestore.py PRE-CREATION 
  ambari-server/src/test/python/TestAmbariServer.py c3651eb 
  ambari-server/src/test/python/TestBackupRestore.py PRE-CREATION 

Diff: https://reviews.apache.org/r/27513/diff/


Testing
-------

Unit Testing
Manual Testing
End2End Testing


Thanks,

Szilard Nemethy

Re: Review Request 27513: Ambari Server HA Phase 1: Provide backup and restore capability

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27513/#review60312
-----------------------------------------------------------



ambari-server/src/main/python/ambari-server.py
<https://reviews.apache.org/r/27513/#comment101679>

    Typically wouldn't use a main like this.  Usually you create an instance of the class and call the methods on it:
    
    backupRestore = BackupRestore(...)
    backupRestore.backup()
    etc.


- Nate Cole


On Nov. 7, 2014, 3:36 a.m., Szilard Nemethy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27513/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2014, 3:36 a.m.)
> 
> 
> Review request for Ambari, Mahadev Konar and Nate Cole.
> 
> 
> Bugs: AMBARI-8068
>     https://issues.apache.org/jira/browse/AMBARI-8068
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Ambari Server HA Phase 1: Provide backup and restore capability
> 
> 
> Diffs
> -----
> 
>   ambari-agent/conf/unix/ambari-agent e867155 
>   ambari-agent/etc/init.d/ambari-agent 898b07e 
>   ambari-agent/src/main/python/ambari_agent/main.py 5d33ca4 
>   ambari-agent/src/test/python/ambari_agent/TestMain.py 7b1a8c8 
>   ambari-server/sbin/ambari-server d4619e9 
>   ambari-server/src/main/python/ambari-server.py b9eaae3 
>   ambari-server/src/main/python/ambari_server/BackupRestore.py PRE-CREATION 
>   ambari-server/src/test/python/TestAmbariServer.py c3651eb 
>   ambari-server/src/test/python/TestBackupRestore.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/27513/diff/
> 
> 
> Testing
> -------
> 
> Unit Testing
> Manual Testing
> End2End Testing
> 
> 
> Thanks,
> 
> Szilard Nemethy
> 
>

Re: Review Request 27513: Ambari Server HA Phase 1: Provide backup and restore capability

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27513/#review60315
-----------------------------------------------------------

Ship it!


Ship It!

- Nate Cole


On Nov. 7, 2014, 3:36 a.m., Szilard Nemethy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27513/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2014, 3:36 a.m.)
> 
> 
> Review request for Ambari, Mahadev Konar and Nate Cole.
> 
> 
> Bugs: AMBARI-8068
>     https://issues.apache.org/jira/browse/AMBARI-8068
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Ambari Server HA Phase 1: Provide backup and restore capability
> 
> 
> Diffs
> -----
> 
>   ambari-agent/conf/unix/ambari-agent e867155 
>   ambari-agent/etc/init.d/ambari-agent 898b07e 
>   ambari-agent/src/main/python/ambari_agent/main.py 5d33ca4 
>   ambari-agent/src/test/python/ambari_agent/TestMain.py 7b1a8c8 
>   ambari-server/sbin/ambari-server d4619e9 
>   ambari-server/src/main/python/ambari-server.py b9eaae3 
>   ambari-server/src/main/python/ambari_server/BackupRestore.py PRE-CREATION 
>   ambari-server/src/test/python/TestAmbariServer.py c3651eb 
>   ambari-server/src/test/python/TestBackupRestore.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/27513/diff/
> 
> 
> Testing
> -------
> 
> Unit Testing
> Manual Testing
> End2End Testing
> 
> 
> Thanks,
> 
> Szilard Nemethy
> 
>

Re: Review Request 27513: Ambari Server HA Phase 1: Provide backup and restore capability

Posted by Szilard Nemethy <sn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27513/
-----------------------------------------------------------

(Updated Nov. 7, 2014, 8:36 a.m.)


Review request for Ambari, Mahadev Konar and Nate Cole.


Changes
-------

Updated patch with the changes suggested


Bugs: AMBARI-8068
    https://issues.apache.org/jira/browse/AMBARI-8068


Repository: ambari


Description
-------

Ambari Server HA Phase 1: Provide backup and restore capability


Diffs (updated)
-----

  ambari-agent/conf/unix/ambari-agent e867155 
  ambari-agent/etc/init.d/ambari-agent 898b07e 
  ambari-agent/src/main/python/ambari_agent/main.py 5d33ca4 
  ambari-agent/src/test/python/ambari_agent/TestMain.py 7b1a8c8 
  ambari-server/sbin/ambari-server d4619e9 
  ambari-server/src/main/python/ambari-server.py b9eaae3 
  ambari-server/src/main/python/ambari_server/BackupRestore.py PRE-CREATION 
  ambari-server/src/test/python/TestAmbariServer.py c3651eb 
  ambari-server/src/test/python/TestBackupRestore.py PRE-CREATION 

Diff: https://reviews.apache.org/r/27513/diff/


Testing
-------

Unit Testing
Manual Testing
End2End Testing


Thanks,

Szilard Nemethy

Re: Review Request 27513: Ambari Server HA Phase 1: Provide backup and restore capability

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27513/#review59569
-----------------------------------------------------------


What is the overall purpose here?


ambari-agent/src/main/python/ambari_agent/main.py
<https://reviews.apache.org/r/27513/#comment100852>

    May want to use os.path.join(agent_keysdir, "*") to make more cross-platform



ambari-server/src/main/python/ambari_server/BackupRestore.py
<https://reviews.apache.org/r/27513/#comment100853>

    Python doc goes inside the method, delimited by triple-quotes:
    
    def perform_backup(self):
      """
      User to perform the actual backup
      """


- Nate Cole


On Nov. 3, 2014, 4:48 a.m., Szilard Nemethy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27513/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2014, 4:48 a.m.)
> 
> 
> Review request for Ambari, Mahadev Konar and Nate Cole.
> 
> 
> Bugs: AMBARI-8068
>     https://issues.apache.org/jira/browse/AMBARI-8068
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Ambari Server HA Phase 1: Provide backup and restore capability
> 
> 
> Diffs
> -----
> 
>   ambari-agent/conf/unix/ambari-agent e867155 
>   ambari-agent/etc/init.d/ambari-agent 898b07e 
>   ambari-agent/src/main/python/ambari_agent/main.py 5d33ca4 
>   ambari-agent/src/test/python/ambari_agent/TestMain.py 7b1a8c8 
>   ambari-server/sbin/ambari-server d4619e9 
>   ambari-server/src/main/python/ambari-server.py 0c5174f 
>   ambari-server/src/main/python/ambari_server/BackupRestore.py PRE-CREATION 
>   ambari-server/src/test/python/TestAmbariServer.py c3651eb 
>   ambari-server/src/test/python/TestBackupRestore.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/27513/diff/
> 
> 
> Testing
> -------
> 
> Unit Testing
> Manual Testing
> End2End Testing
> 
> 
> Thanks,
> 
> Szilard Nemethy
> 
>