You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2019/12/13 02:09:46 UTC

[GitHub] [maven-checkstyle-plugin] rnveach commented on a change in pull request #18: [MCHECKSTYLE-381] remove call to checker.setClassLoader().

rnveach commented on a change in pull request #18: [MCHECKSTYLE-381] remove call to checker.setClassLoader().
URL: https://github.com/apache/maven-checkstyle-plugin/pull/18#discussion_r357458054
 
 

 ##########
 File path: src/main/java/org/apache/maven/plugins/checkstyle/exec/DefaultCheckstyleExecutor.java
 ##########
 @@ -201,8 +201,6 @@ public URLClassLoader run()
             }
         } );
 
-        checker.setClassLoader( projectClassLoader );
 
 Review comment:
   Variable `projectClassLoader` still remains and all it does it call close a few lines down. Seems to me it can be completely removed now.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services