You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2025/10/06 23:11:59 UTC
[kudu-CR] KUDU-3704 fix crash in C++ client
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23496
Change subject: KUDU-3704 fix crash in C++ client
......................................................................
KUDU-3704 fix crash in C++ client
The bug has been introduced with KUDU-3461.
[1] https://issues.apache.org/jira/browse/KUDU-3461
Change-Id: I317217fe487930770768ba045b65f5fe2928833c
---
M src/kudu/client/client-test.cc
M src/kudu/client/meta_cache.cc
2 files changed, 55 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/96/23496/1
--
To view, visit http://gerrit.cloudera.org:8080/23496
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I317217fe487930770768ba045b65f5fe2928833c
Gerrit-Change-Number: 23496
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] KUDU-3704 fix crash in C++ client
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/23496 )
Change subject: KUDU-3704 fix crash in C++ client
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/23496
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I317217fe487930770768ba045b65f5fe2928833c
Gerrit-Change-Number: 23496
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Tue, 07 Oct 2025 16:21:58 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3704 fix crash in C++ client
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: KUDU-3704 fix crash in C++ client
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/23496
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I317217fe487930770768ba045b65f5fe2928833c
Gerrit-Change-Number: 23496
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-3704 fix crash in C++ client
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23496 )
Change subject: KUDU-3704 fix crash in C++ client
......................................................................
Patch Set 1:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1951/
--
To view, visit http://gerrit.cloudera.org:8080/23496
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I317217fe487930770768ba045b65f5fe2928833c
Gerrit-Change-Number: 23496
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 06 Oct 2025 23:12:07 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3704 fix crash in C++ client
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23496 )
Change subject: KUDU-3704 fix crash in C++ client
......................................................................
KUDU-3704 fix crash in C++ client
The bug has been introduced with KUDU-3461.
[1] https://issues.apache.org/jira/browse/KUDU-3461
Change-Id: I317217fe487930770768ba045b65f5fe2928833c
Reviewed-on: http://gerrit.cloudera.org:8080/23496
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Marton Greber <gr...@gmail.com>
Reviewed-by: Gabriella Lotz <lo...@gmail.com>
---
M src/kudu/client/client-test.cc
M src/kudu/client/meta_cache.cc
2 files changed, 55 insertions(+), 2 deletions(-)
Approvals:
Alexey Serbin: Verified
Marton Greber: Looks good to me, approved
Gabriella Lotz: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.cloudera.org:8080/23496
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I317217fe487930770768ba045b65f5fe2928833c
Gerrit-Change-Number: 23496
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
[kudu-CR] KUDU-3704 fix crash in C++ client
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23496 )
Change subject: KUDU-3704 fix crash in C++ client
......................................................................
Patch Set 1: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1951/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/23496
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I317217fe487930770768ba045b65f5fe2928833c
Gerrit-Change-Number: 23496
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 07 Oct 2025 00:35:50 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3704 fix crash in C++ client
Posted by "Gabriella Lotz (Code Review)" <ge...@cloudera.org>.
Gabriella Lotz has posted comments on this change. ( http://gerrit.cloudera.org:8080/23496 )
Change subject: KUDU-3704 fix crash in C++ client
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/23496
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I317217fe487930770768ba045b65f5fe2928833c
Gerrit-Change-Number: 23496
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Tue, 07 Oct 2025 08:34:57 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3704 fix crash in C++ client
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23496 )
Change subject: KUDU-3704 fix crash in C++ client
......................................................................
Patch Set 1: Verified+1
unrelated java test failure (TSAN): org.apache.kudu.client.TestKuduClient
--
To view, visit http://gerrit.cloudera.org:8080/23496
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I317217fe487930770768ba045b65f5fe2928833c
Gerrit-Change-Number: 23496
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 07 Oct 2025 02:16:17 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3704 fix crash in C++ client
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/23496 )
Change subject: KUDU-3704 fix crash in C++ client
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/23496
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I317217fe487930770768ba045b65f5fe2928833c
Gerrit-Change-Number: 23496
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Tue, 07 Oct 2025 08:34:38 +0000
Gerrit-HasComments: No