[GitHub] [james-project] quantranhong1999 commented on a diff in pull request #1320: JAMES-3461 - Fix Mailbox/changes do not take isSubscribe changes into account

[GitBox <gi...@apache.org>]

quantranhong1999 commented on code in PR #1320:
URL: https://github.com/apache/james-project/pull/1320#discussion_r1037758804


##########
server/protocols/jmap-rfc-8621-integration-tests/jmap-rfc-8621-integration-tests-common/src/main/scala/org/apache/james/jmap/rfc8621/contract/MailboxSetMethodContract.scala:
##########
@@ -8080,15 +8080,15 @@ trait MailboxSetMethodContract {
       .subscribeOn(Schedulers.boundedElastic())
       .subscribe()
 
-    Thread.sleep(200)
-    // change subscription
-    JmapRequests.subscribe(mailboxId.serialize())
-
     Awaitility.`with`
       .pollInterval(Duration.ofMillis(100))
       .atMost(Duration.ofSeconds(100))
       .await
       .untilAsserted { () =>
+        // change subscription
+        JmapRequests.subscribe(mailboxId.serialize())
+        Thread.sleep(200)

Review Comment:
   This looks weird to me because this change the expected behavior: now we subscribe many times and expect only the first StateChangeEvent.  Anyway...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org