[jira] [Commented] (PHOENIX-5896) Implement incremental rebuild along the failed regions in IndexTool

["Hadoop QA (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-5896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17110485#comment-17110485 ] 

Hadoop QA commented on PHOENIX-5896:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/13003302/PHOENIX-5896.4.x.v2.patch
  against 4.x branch at commit 49599fd89b6cfa9cab9d7d3f6dcf4bdc5428915a.
  ATTACHMENT ID: 13003302

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 7 new or modified tests.

    {color:red}-1 javac{color}.  The applied patch generated 303 javac compiler warnings (more than the master's current 302 warnings).

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than 100:
    +                    + " (ID INTEGER NOT NULL PRIMARY KEY, NAME VARCHAR, CODE VARCHAR) "+tableDDLOptions);
+                    "CREATE INDEX %s ON %s (NAME) INCLUDE (CODE)", indexTableName, dataTableFullName));
+            conn.createStatement().execute("upsert into " + dataTableFullName + " values (1, 'Phoenix', 'A')");
+            conn.createStatement().execute("upsert into " + dataTableFullName + " values (2, 'Phoenix1', 'B')");
+            IndexTool it = IndexToolIT.runIndexTool(directApi, useSnapshot, schemaName, dataTableName, indexTableName,
+            it = IndexToolIT.runIndexTool(directApi, useSnapshot, schemaName, dataTableName, indexTableName,
+            it = IndexToolIT.runIndexTool(directApi, useSnapshot, schemaName, dataTableName, indexTableName,
+            ResultSet rs = conn.createStatement().executeQuery("SELECT * FROM " + indexTableFullName);
+    private String getRunStatusFromResultTable(Connection conn, Long scn) throws SQLException, IOException {
+                            IndexTool.IndexVerifyType verifyType, Long startTime, Long endTime, Long incrementalVerify) {

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.phoenix.index.ShouldVerifyTest

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/3862//testReport/
Code Coverage results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/3862//artifact/phoenix-core/target/site/jacoco/index.html
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/3862//console

This message is automatically generated.

> Implement incremental rebuild along the failed regions in IndexTool
> -------------------------------------------------------------------
>
>                 Key: PHOENIX-5896
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5896
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Swaroopa Kadam
>            Assignee: Swaroopa Kadam
>            Priority: Major
>         Attachments: PHOENIX-5896.4.x.v1.patch, PHOENIX-5896.4.x.v2.patch
>
>          Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> As we run the index tool on indexes to be rebuilt after the upgrade, it spends some time in rescanning successful regions from the last rebuild. We want to make the index tool a little smarter to not rebuild rows from the regions that were found in the PIT_result table from the last rebuild. PIT_result logs region info if it was successfully rebuilt in the last run.   



--
This message was sent by Atlassian Jira
(v8.3.4#803005)