[GitHub] [incubator-doris] imay commented on a change in pull request #1617: Add PreAgg Hint

[GitBox <gi...@apache.org>]

imay commented on a change in pull request #1617: Add PreAgg Hint
URL: https://github.com/apache/incubator-doris/pull/1617#discussion_r312728254
 
 

 ##########
 File path: fe/src/main/java/org/apache/doris/planner/SingleNodePlanner.java
 ##########
 @@ -593,8 +595,20 @@ private void turnOffPreAgg(AggregateInfo aggInfo, SelectStmt selectStmt, Analyze
             olapNode.setIsPreAggregation(true, null);
         } while (false);
 
-        if ((root instanceof OlapScanNode) && turnOffReason != null) {
-            ((OlapScanNode) root).setIsPreAggregation(false, turnOffReason);
+        if ((root instanceof OlapScanNode)) {
+            OlapScanNode node = (OlapScanNode) root;
+            for (TableRef tableRef : selectStmt.getTableRefs()) {// Force Open PreAgg
 
 Review comment:
   what do this logic means to do?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
For additional commands, e-mail: dev-help@doris.apache.org