[GitHub] [lucene] romseygeek opened a new pull request #727: LUCENE-10431: Don't include rewriteMethod in MTQ hash calculation

[GitBox <gi...@apache.org>]

romseygeek opened a new pull request #727:
URL: https://github.com/apache/lucene/pull/727


   BooleanQuery assumes that its children's hashcodes are stable, and has some
   assertions to this effect.  This did not apply to MultiTermQuery, which has a 
   mutable RewriteMethod member variable that was included in its hash calculation.
   Changing the rewrite method would change the hash, leading to assertion failures
   being tripped.  This commit removes rewriteMethod from the hash calculation,
   meaning that the hashcode will be stable even under mutability.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene] romseygeek merged pull request #727: LUCENE-10431: Don't include rewriteMethod in MTQ hash calculation

[GitBox <gi...@apache.org>]

romseygeek merged pull request #727:
URL: https://github.com/apache/lucene/pull/727


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org