You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "minbo-wang (via GitHub)" <gi...@apache.org> on 2023/06/19 09:51:53 UTC
[GitHub] [tvm] minbo-wang opened a new pull request, #15121: GraphExecutor: Fix wild pointer assign when input and output are reshape
minbo-wang opened a new pull request, #15121:
URL: https://github.com/apache/tvm/pull/15121
If reshape in our relay expression, like reshape + matmul expr, when we use set_input_zero_copy or set_output_zero_copy，the result goes wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] minbo-wang commented on pull request #15121: GraphExecutor: Fix wild pointer assign when input and output are reshape
Posted by "minbo-wang (via GitHub)" <gi...@apache.org>.
minbo-wang commented on PR #15121:
URL: https://github.com/apache/tvm/pull/15121#issuecomment-1596952465
> Could you please add correspondent unit tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] echuraev commented on a diff in pull request #15121: GraphExecutor: Fix wild pointer assign when input and output are reshape
Posted by "echuraev (via GitHub)" <gi...@apache.org>.
echuraev commented on code in PR #15121:
URL: https://github.com/apache/tvm/pull/15121#discussion_r1236398167
##########
tests/python/contrib/test_reshape_0_copy.py:
##########
Review Comment:
IMHO, I would say that better use `zero` instead of `0` in the name of the file, e.g `test_reshape_zero_copy.py`.
Also, probably you can move this test to the [file](https://github.com/apache/tvm/blob/main/tests/python/unittest/test_runtime_module_based_interface.py#L693) with existing tests on zero_copy.
##########
src/runtime/graph_executor/graph_executor.cc:
##########
@@ -566,7 +588,7 @@ std::pair<std::function<void()>, std::shared_ptr<GraphExecutor::OpArgs>> GraphEx
}
if (param.func_name == "__nop") {
- return {[]() {}, arg_ptr};
+ return {[arg_ptr]() {}, arg_ptr};
Review Comment:
What is the reason of capturing `arg_ptr` in empty lambda?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] minbo-wang commented on pull request #15121: GraphExecutor: Fix wild pointer assign when input and output are reshape
Posted by "minbo-wang (via GitHub)" <gi...@apache.org>.
minbo-wang commented on PR #15121:
URL: https://github.com/apache/tvm/pull/15121#issuecomment-1596961918
> Could you please add correspondent unit tests?
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] minbo-wang closed pull request #15121: GraphExecutor: Fix wild pointer assign when input and output are reshape
Posted by "minbo-wang (via GitHub)" <gi...@apache.org>.
minbo-wang closed pull request #15121: GraphExecutor: Fix wild pointer assign when input and output are reshape
URL: https://github.com/apache/tvm/pull/15121
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tvm-bot commented on pull request #15121: GraphExecutor: Fix wild pointer assign when input and output are reshape
Posted by "tvm-bot (via GitHub)" <gi...@apache.org>.
tvm-bot commented on PR #15121:
URL: https://github.com/apache/tvm/pull/15121#issuecomment-1596871034
<!---bot-comment-->
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
<!--bot-comment-ccs-start-->
* No users to auto-tag found, no teams are specified in PR title <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
<sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org