You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/09/18 10:46:42 UTC
[GitHub] [incubator-eventmesh] pchengma opened a new pull request, #1308: [ISSUE #1307] Support Cluster-Mode and Broadcast-Mode Listener in Knative-Connector.
pchengma opened a new pull request, #1308:
URL: https://github.com/apache/incubator-eventmesh/pull/1308
<!--
### Contribution Checklist
- Name the pull request in the form "[ISSUE #XXXX] Title of the pull request",
where *XXXX* should be replaced by the actual issue number.
Skip *[ISSUE #XXXX]* if there is no associated github issue for this pull request.
- Fill out the template below to describe the changes contributed by the pull request.
That will give reviewers the context they need to do the review.
- Each pull request should address only one issue.
Please do not mix up code from multiple issues.
- Each commit in the pull request should have a meaningful commit message.
- Once all items of the checklist are addressed, remove the above text and this checklist,
leaving only the filled out template below.
(The sections below can be removed for hotfixes of typos)
-->
<!--
(If this PR fixes a GitHub issue, please add `Fixes #<XXX>` or `Cloese #<XXX>`.)
-->
Fixed #1307.
### Motivation
*Supported cluster-mode and broadcast-mode listener in Knative-Connector.*
*This PR for ISSUE #1307 will be first merged into knative-connector branch.*
### Modifications
#### Implementation
- Changed return type of pullMessage to CloudEvent
- Changed data type in ConcurrentMap<String, CloudEvent> subscriptionInner, which is used to store subscribed message
- Added direct ```consume``` by listener after ```subscribe``` according to action type (CommitMessage, ReconsumeLater, and ManualACK) and mode (cluster or broadcast)
- Added broadcast-mode listener
#### How to Test
Same as the steps in demo (see [document](https://github.com/apache/incubator-eventmesh/blob/master/docs/zh/connector-knative/01-eventmesh-connector-knative.md) for details).
### Documentation
- Does this pull request introduce a new feature? Yes
- If yes, how is the feature documented? Not documented.
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation. The documentation issue will be created along with another PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] codecov[bot] commented on pull request #1308: [ISSUE #1307] Support Cluster-Mode and Broadcast-Mode Listener in Knative-Connector.
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #1308:
URL: https://github.com/apache/incubator-eventmesh/pull/1308#issuecomment-1250311400
# [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/1308?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1308](https://codecov.io/gh/apache/incubator-eventmesh/pull/1308?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (db00f37) into [knative-connector](https://codecov.io/gh/apache/incubator-eventmesh/commit/b53b3df5890b7dd59f316215640b6b90b0932f64?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b53b3df) will **decrease** coverage by `0.32%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## knative-connector #1308 +/- ##
======================================================
- Coverage 10.11% 9.79% -0.33%
+ Complexity 649 626 -23
======================================================
Files 380 380
Lines 23364 23419 +55
Branches 2551 2555 +4
======================================================
- Hits 2364 2294 -70
- Misses 20794 20916 +122
- Partials 206 209 +3
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-eventmesh/pull/1308?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ctor/knative/cloudevent/KnativeMessageFactory.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1308/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1rbmF0aXZlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL2tuYXRpdmUvY2xvdWRldmVudC9LbmF0aXZlTWVzc2FnZUZhY3RvcnkuamF2YQ==) | `66.66% <0.00%> (-33.34%)` | :arrow_down: |
| [.../knative/cloudevent/impl/KnativeMessageWriter.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1308/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1rbmF0aXZlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL2tuYXRpdmUvY2xvdWRldmVudC9pbXBsL0tuYXRpdmVNZXNzYWdlV3JpdGVyLmphdmE=) | `27.77% <0.00%> (-38.89%)` | :arrow_down: |
| [...sh/connector/knative/consumer/DefaultConsumer.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1308/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1rbmF0aXZlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL2tuYXRpdmUvY29uc3VtZXIvRGVmYXVsdENvbnN1bWVyLmphdmE=) | `0.00% <0.00%> (-62.50%)` | :arrow_down: |
| [...h/connector/knative/consumer/PullConsumerImpl.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1308/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1rbmF0aXZlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL2tuYXRpdmUvY29uc3VtZXIvUHVsbENvbnN1bWVySW1wbC5qYXZh) | `0.00% <0.00%> (-40.00%)` | :arrow_down: |
| [...ve/patch/EventMeshMessageListenerConcurrently.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1308/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1rbmF0aXZlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL2tuYXRpdmUvcGF0Y2gvRXZlbnRNZXNoTWVzc2FnZUxpc3RlbmVyQ29uY3VycmVudGx5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...connector/ConnectorResourceServiceKnativeImpl.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1308/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1rbmF0aXZlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL2tuYXRpdmUvY29ubmVjdG9yL0Nvbm5lY3RvclJlc291cmNlU2VydmljZUtuYXRpdmVJbXBsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...onnector/knative/consumer/KnativeConsumerImpl.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1308/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1rbmF0aXZlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL2tuYXRpdmUvY29uc3VtZXIvS25hdGl2ZUNvbnN1bWVySW1wbC5qYXZh) | `0.00% <0.00%> (-62.50%)` | :arrow_down: |
| [...ava/org/apache/eventmesh/common/utils/IPUtils.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1308/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi91dGlscy9JUFV0aWxzLmphdmE=) | `33.33% <0.00%> (-6.49%)` | :arrow_down: |
| ... and [2 more](https://codecov.io/gh/apache/incubator-eventmesh/pull/1308/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 merged pull request #1308: [ISSUE #1315] Knative Connector: Remove Unnecessary Unit Test of Consumer.
Posted by GitBox <gi...@apache.org>.
xwm1992 merged PR #1308:
URL: https://github.com/apache/incubator-eventmesh/pull/1308
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org