[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #339: [FLINK-28749] Include resource type in KubernetesOperatorResourceNamespaceMetricGroup

[GitBox <gi...@apache.org>]

gyfora commented on code in PR #339:
URL: https://github.com/apache/flink-kubernetes-operator/pull/339#discussion_r938539685


##########
flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/metrics/OperatorJosdkMetricsTest.java:
##########
@@ -45,15 +48,18 @@
 /** {@link OperatorJosdkMetrics} tests. */
 public class OperatorJosdkMetricsTest {
 
-    private final ResourceID resourceId = new ResourceID("testname", "testns");
-    private final String controllerName = FlinkDeploymentController.class.getSimpleName();
-    private final String resourcePrefix =
-            "testhost.k8soperator.flink-operator-test.testopname.resource.testns.testname.JOSDK.";
-    private final String systemPrefix =
+    private static final ResourceID resourceId = new ResourceID("testname", "testns");
+    private static final String controllerName = FlinkDeploymentController.class.getSimpleName();
+    private static final String resourcePrefix =

Review Comment:
   I will try to improve this, good point



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org