You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Gavin (JIRA)" <ji...@apache.org> on 2018/08/01 06:22:10 UTC
[jira] [Issue Comment Deleted] (HBASE-18834) fix shellcheck warning
on hbase personality
[ https://issues.apache.org/jira/browse/HBASE-18834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gavin updated HBASE-18834:
--------------------------
Comment: was deleted
(was: A comment with security level 'jira-users' was removed.)
> fix shellcheck warning on hbase personality
> -------------------------------------------
>
> Key: HBASE-18834
> URL: https://issues.apache.org/jira/browse/HBASE-18834
> Project: HBase
> Issue Type: Bug
> Components: test
> Reporter: Sean Busbey
> Assignee: Sean Busbey
> Priority: Minor
> Fix For: 2.0.0-alpha-4, 2.0.0
>
> Attachments: HBASE-18834.0.patch
>
>
> current shellcheck gives us two warnings:
> {code}
> $ shellcheck dev-support/hbase-personality.sh
> In dev-support/hbase-personality.sh line 123:
> if [[ $? -eq 0 ]]; then
> ^-- SC2181: Check exit code directly with e.g. 'if mycmd;', not indirectly with $?.
> In dev-support/hbase-personality.sh line 136:
> if [[ $? -eq 0 ]]; then
> ^-- SC2181: Check exit code directly with e.g. 'if mycmd;', not indirectly with $?.
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)