[GitHub] [spark] MaxGekk commented on a change in pull request #32123: [SPARK-34562][SQL] Add test and doc for Parquet Bloom filter push down

[GitBox <gi...@apache.org>]

MaxGekk commented on a change in pull request #32123:
URL: https://github.com/apache/spark/pull/32123#discussion_r611210096



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala
##########
@@ -1634,6 +1634,34 @@ abstract class ParquetFilterSuite extends QueryTest with ParquetTest with Shared
       }
     }
   }
+
+  test("SPARK-34562: Bloom filter push down") {
+    withTempPath { dir =>
+      val path = dir.toURI.toString
+      spark.range(100).selectExpr("id * 2 AS id").write
+        .option(ParquetOutputFormat.BLOOM_FILTER_ENABLED + "#id", "true")

Review comment:
       nit: "true" -> true

##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala
##########
@@ -1634,6 +1634,34 @@ abstract class ParquetFilterSuite extends QueryTest with ParquetTest with Shared
       }
     }
   }
+
+  test("SPARK-34562: Bloom filter push down") {
+    withTempPath { dir =>
+      val path = dir.toURI.toString

Review comment:
       Any reasons to no just `dir.getCanonicalPath`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org