You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/04/03 11:38:21 UTC

[GitHub] [airflow] mik-laj commented on a change in pull request #15146: Validate that the extra parameter is parseable as JSON

mik-laj commented on a change in pull request #15146:
URL: https://github.com/apache/airflow/pull/15146#discussion_r606654260



##########
File path: airflow/models/connection.py
##########
@@ -137,7 +137,25 @@ def __init__(  # pylint: disable=too-many-arguments
             self.password = password
             self.schema = schema
             self.port = port
-            self.extra = extra
+            self.extra = self.validate_extra(extra)
+
+    @staticmethod
+    def validate_extra(extra: str):

Review comment:
       `None` is also the correct value. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org