You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/07/10 18:08:38 UTC
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10284: fix(explore): edit datasource does not update control states
codecov-commenter edited a comment on pull request #10284:
URL: https://github.com/apache/incubator-superset/pull/10284#issuecomment-656811110
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10284?src=pr&el=h1) Report
> Merging [#10284](https://codecov.io/gh/apache/incubator-superset/pull/10284?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/4e4ccd48d64adf187dbc682ebf68a3954a37b943&el=desc) will **decrease** coverage by `4.74%`.
> The diff coverage is `44.44%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10284?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10284 +/- ##
==========================================
- Coverage 70.24% 65.49% -4.75%
==========================================
Files 598 598
Lines 32021 32016 -5
Branches 3234 3236 +2
==========================================
- Hits 22493 20969 -1524
- Misses 9423 10866 +1443
- Partials 105 181 +76
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.39% <44.44%> (-0.01%)` | :arrow_down: |
| #python | `69.74% <ø> (+0.02%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10284?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...uperset-frontend/src/components/TooltipWrapper.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10284/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVG9vbHRpcFdyYXBwZXIuanN4) | `100.00% <ø> (ø)` | |
| [...nd/src/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10284/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlVmlld0NvbnRhaW5lci5qc3g=) | `46.85% <ø> (-30.77%)` | :arrow_down: |
| [superset-frontend/src/explore/controlUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/10284/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFV0aWxzLmpz) | `94.39% <ø> (-1.87%)` | :arrow_down: |
| [superset-frontend/src/explore/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10284/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbHMuanN4) | `15.85% <0.00%> (+0.19%)` | :arrow_up: |
| [.../explore/components/controls/DatasourceControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10284/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC5qc3g=) | `65.78% <50.00%> (-12.34%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10284/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10284/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10284/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10284/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10284/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [145 more](https://codecov.io/gh/apache/incubator-superset/pull/10284/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10284?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10284?src=pr&el=footer). Last update [4e4ccd4...0880ad3](https://codecov.io/gh/apache/incubator-superset/pull/10284?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org