You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "PakhomovAlexander (via GitHub)" <gi...@apache.org> on 2024/03/13 15:00:04 UTC
Re: [PR] IGNITE-21428 Additional WITH params for zone [ignite-3]
PakhomovAlexander commented on code in PR #3374:
URL: https://github.com/apache/ignite-3/pull/3374#discussion_r1523422093
##########
modules/catalog-dsl/src/main/java/org/apache/ignite/internal/catalog/sql/CreateZoneImpl.java:
##########
@@ -75,6 +70,53 @@ CreateZoneImpl partitions(Integer n) {
return this;
}
+ CreateZoneImpl affinity(String affinity) {
+ Objects.requireNonNull(affinity, "Affinity function must not be null");
+
+ withOptions.add(WithOption.affinity(affinity));
+ return this;
+ }
+
+ CreateZoneImpl dataNodesAutoAdjust(Integer adjust) {
+ Objects.requireNonNull(adjust, "Timeout must not be null");
+
+ withOptions.add(WithOption.dataNodesAutoAdjust(adjust));
+ return this;
+ }
+
+ CreateZoneImpl dataNodesAutoAdjustScaleUp(Integer adjust) {
+ Objects.requireNonNull(adjust, "Timeout must not be null");
Review Comment:
same
##########
modules/catalog-dsl/src/main/java/org/apache/ignite/internal/catalog/sql/CreateZoneImpl.java:
##########
@@ -75,6 +70,53 @@ CreateZoneImpl partitions(Integer n) {
return this;
}
+ CreateZoneImpl affinity(String affinity) {
+ Objects.requireNonNull(affinity, "Affinity function must not be null");
+
+ withOptions.add(WithOption.affinity(affinity));
+ return this;
+ }
+
+ CreateZoneImpl dataNodesAutoAdjust(Integer adjust) {
+ Objects.requireNonNull(adjust, "Timeout must not be null");
Review Comment:
What timeout must not be null?
##########
modules/catalog-dsl/src/main/java/org/apache/ignite/internal/catalog/sql/CreateZoneImpl.java:
##########
@@ -75,6 +70,53 @@ CreateZoneImpl partitions(Integer n) {
return this;
}
+ CreateZoneImpl affinity(String affinity) {
+ Objects.requireNonNull(affinity, "Affinity function must not be null");
+
+ withOptions.add(WithOption.affinity(affinity));
+ return this;
+ }
+
+ CreateZoneImpl dataNodesAutoAdjust(Integer adjust) {
+ Objects.requireNonNull(adjust, "Timeout must not be null");
+
+ withOptions.add(WithOption.dataNodesAutoAdjust(adjust));
+ return this;
+ }
+
+ CreateZoneImpl dataNodesAutoAdjustScaleUp(Integer adjust) {
+ Objects.requireNonNull(adjust, "Timeout must not be null");
+
+ withOptions.add(WithOption.dataNodesAutoAdjustScaleUp(adjust));
+ return this;
+ }
+
+ CreateZoneImpl dataNodesAutoAdjustScaleDown(Integer adjust) {
+ Objects.requireNonNull(adjust, "Timeout must not be null");
Review Comment:
same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org