You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by si...@apache.org on 2018/06/01 06:26:14 UTC
[bookkeeper] branch master updated: BP-33: Move releasing official
docker images out of main repo
This is an automated email from the ASF dual-hosted git repository.
sijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/bookkeeper.git
The following commit(s) were added to refs/heads/master by this push:
new a804fae BP-33: Move releasing official docker images out of main repo
a804fae is described below
commit a804faeafe40e1ffd74e85e8f7104811c02cd8c4
Author: Sijie Guo <si...@apache.org>
AuthorDate: Thu May 31 23:26:04 2018 -0700
BP-33: Move releasing official docker images out of main repo
Descriptions of the changes in this PR:
*Motivation*
Current bookkeeper docker images are auto-built by apache docker account. However it becomes problematic in the release process:
Docker autobuild uses release tag for labeling the versions for docker images. But the Dockerfile can only be updated after a release is successfully made. So we have to retag a release after a release, in order to update Dockerfile to build the docker images.
Master Issue: #1449
Author: Sijie Guo <si...@apache.org>
Reviewers: Ivan Kelly <iv...@apache.org>, Enrico Olivelli <eo...@gmail.com>, Jia Zhai <None>, Sijie Guo <si...@apache.org>
This closes #1450 from sijie/official_docker_images
---
site/bps/BP-33-building-official-docker-imags.md | 40 ++++++++++++++++++++++++
site/community/bookkeeper_proposals.md | 3 +-
2 files changed, 42 insertions(+), 1 deletion(-)
diff --git a/site/bps/BP-33-building-official-docker-imags.md b/site/bps/BP-33-building-official-docker-imags.md
new file mode 100644
index 0000000..d50cac1
--- /dev/null
+++ b/site/bps/BP-33-building-official-docker-imags.md
@@ -0,0 +1,40 @@
+---
+title: "BP-33: Move releasing official docker images out of main repo"
+issue: https://github.com/apache/bookkeeper/1449
+state: "Under Discussion"
+release: "4.7.1"
+---
+
+### Motivation
+
+Current bookkeeper docker images are auto-built by apache docker account. However it becomes problematic in the release process:
+
+Docker autobuild uses release tag for labeling the versions for docker images. But the `Dockerfile` can only be updated after
+a release is successfully made. So we have to retag a release after a release, in order to update `Dockerfile` to build the docker
+image.
+
+### Proposed Changes
+
+Follow what `flink` is doing, and maintain the docker files outside of the bookkeeper main repo.
+
+- Create an organization `asfbookkeeper-ecosystem` for hosting repos that related bookkeeper but not necessarily needed to be put in main repo.
+- Create a repo `docker-bookkeeper` under `asfbookkeeper-ecosystem` for hosting the docker files following the suggested practices from making a docker official image.
+- Add a library definition file under `docker-library/official-images` for bookkeeper.
+- Add an image doc under `docker-library/docs` for bookkeeper.
+- Update the release guide on how to update docker images at the end of each release.
+- Remove `docker` dir from main repo or make it used for building *unreleased* docker images only.
+- Disable docker autobuild from apache account.
+
+Proposed docker file repo: https://github.com/asfbookkeeper-ecosystem/docker-bookkeeper
+
+### Compatibility, Deprecation, and Migration Plan
+
+N/A
+
+### Test Plan
+
+N/A
+
+### Rejected Alternatives
+
+N/A
diff --git a/site/community/bookkeeper_proposals.md b/site/community/bookkeeper_proposals.md
index dc2fe99..425c18e 100644
--- a/site/community/bookkeeper_proposals.md
+++ b/site/community/bookkeeper_proposals.md
@@ -85,7 +85,7 @@ using Google Doc.
This section lists all the _bookkeeper proposals_ made to BookKeeper.
-*Next Proposal Number: 33*
+*Next Proposal Number: 34*
### Inprogress
@@ -104,6 +104,7 @@ Proposal | State
[BP-30: BookKeeper Table Service](https://docs.google.com/document/d/155xAwWv5IdOitHh1NVMEwCMGgB28M3FyMiQSxEpjE-Y/edit#heading=h.56rbh52koe3f) | Accepted
[BP-31: BookKeeper Durability Anchor](../../bps/BP-31-durability) | Accepted
[BP-32: Advisory (optimistic) write close](../../bps/BP-32-advisory-write-close) | Accepted
+[BP-33: Move releasing docker images out of main repo](../../bps/BP-33-building-official-docker-imags) | Draft
### Adopted
--
To stop receiving notification emails like this one, please contact
sijie@apache.org.