You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/02/08 11:32:41 UTC

[GitHub] [apisix-dashboard] Jaycean edited a comment on pull request #1452: feat(be): refactor upstream unit test

Jaycean edited a comment on pull request #1452:
URL: https://github.com/apache/apisix-dashboard/pull/1452#issuecomment-775079236


   > @Jaycean What is the current code coverage of `upstream.go`? It's a little strange that this pr doesn't show coverage
   
   yeah,My local run test coverage is 79.1%
   ```
       --- PASS: TestUpstream_ListUpstreamNames/get_upstream_list_names (0.00s)
       --- PASS: TestUpstream_ListUpstreamNames/get_upstream_list_names_nil (0.00s)
   PASS
   coverage: 79.1% of statements
   ok      github.com/apisix/manager-api/internal/handler/upstream 1.091s  coverage: 79.1% of statements
   ```
   
   It's really a bit strange. I'll see if there's a similar situation in other PR, no codecov report.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org