[PR] [FLINK-35935][table-planner] Fix RTAS not supporting LIMIT [flink]

["xuyangzhong (via GitHub)" <gi...@apache.org>]

xuyangzhong opened a new pull request, #25201:
URL: https://github.com/apache/flink/pull/25201

   ## What is the purpose of the change
   
   BP for https://github.com/apache/flink/pull/25185.
   
   *When using `SqlReplaceTableAsConverter` to convert SqlNode,  `SqlReplaceTableAsConverter` wrongly used the original query `asQuerySqlNode`. Actually it should use the validated SqlNode.*
   
   
   ## Brief change log
   
     - *Use validated SqlNode when converting RTAS*
     - *Add full tests*
   
   ## Verifying this change
   
   Many tests (including UT and IT) have been added to verify this pr.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-35935][table-planner] Fix RTAS not supporting LIMIT [flink]

["flinkbot (via GitHub)" <gi...@apache.org>]

flinkbot commented on PR #25201:
URL: https://github.com/apache/flink/pull/25201#issuecomment-2290322342

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b70b743b4747fcfedf393b02bfc896dd54fb724e",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "b70b743b4747fcfedf393b02bfc896dd54fb724e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b70b743b4747fcfedf393b02bfc896dd54fb724e UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-35935][table-planner] Fix RTAS not supporting LIMIT [flink]

["lincoln-lil (via GitHub)" <gi...@apache.org>]

lincoln-lil merged PR #25201:
URL: https://github.com/apache/flink/pull/25201


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org