You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/07/06 14:59:05 UTC

[GitHub] [beam] annaqin418 commented on a change in pull request #12157: [BEAM-7587] Spark portable streaming

annaqin418 commented on a change in pull request #12157:
URL: https://github.com/apache/beam/pull/12157#discussion_r450281739



##########
File path: runners/spark/src/main/java/org/apache/beam/runners/spark/translation/SparkTranslationContext.java
##########
@@ -35,15 +35,15 @@
  * compute them after translation.
  */
 public class SparkTranslationContext {
-  private final JavaSparkContext jsc;
+  protected final JavaSparkContext jsc;

Review comment:
       You're right, they shouldn't be, I got confused with the inheritance




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org