You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@celeborn.apache.org by an...@apache.org on 2022/11/29 07:25:42 UTC

[incubator-celeborn] branch main updated: [CELEBORN-79][REFACTOR] Remove unused responseCheckerThread from LifecycleManager (#1022)

This is an automated email from the ASF dual-hosted git repository.

angerszhuuuu pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-celeborn.git


The following commit(s) were added to refs/heads/main by this push:
     new 01dc9d42 [CELEBORN-79][REFACTOR] Remove unused responseCheckerThread from LifecycleManager (#1022)
01dc9d42 is described below

commit 01dc9d4259e78689169f0709d44c3f8469c9c041
Author: Angerszhuuuu <an...@gmail.com>
AuthorDate: Tue Nov 29 15:25:37 2022 +0800

    [CELEBORN-79][REFACTOR] Remove unused responseCheckerThread from LifecycleManager (#1022)
---
 .../src/main/scala/org/apache/celeborn/client/LifecycleManager.scala  | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/client/src/main/scala/org/apache/celeborn/client/LifecycleManager.scala b/client/src/main/scala/org/apache/celeborn/client/LifecycleManager.scala
index bed13215..c505acd2 100644
--- a/client/src/main/scala/org/apache/celeborn/client/LifecycleManager.scala
+++ b/client/src/main/scala/org/apache/celeborn/client/LifecycleManager.scala
@@ -166,8 +166,6 @@ class LifecycleManager(appId: String, val conf: CelebornConf) extends RpcEndpoin
   private val appHeartbeatHandlerThread =
     ThreadUtils.newDaemonSingleThreadScheduledExecutor("app-heartbeat")
   private var appHeartbeat: ScheduledFuture[_] = _
-  private val responseCheckerThread =
-    ThreadUtils.newDaemonSingleThreadScheduledExecutor("rss-master-resp-checker")
 
   private val batchHandleChangePartitionEnabled = conf.batchHandleChangePartitionEnabled
   private val batchHandleChangePartitionExecutors = ThreadUtils.newDaemonCachedThreadPool(
@@ -425,8 +423,6 @@ class LifecycleManager(appId: String, val conf: CelebornConf) extends RpcEndpoin
     appHeartbeat.cancel(true)
     ThreadUtils.shutdown(appHeartbeatHandlerThread, 800.millis)
 
-    ThreadUtils.shutdown(responseCheckerThread, 800.millis)
-
     rssHARetryClient.close()
     if (rpcEnv != null) {
       rpcEnv.shutdown()