[GitHub] [spark] srowen commented on a change in pull request #31624: [SPARK-34392][SQL] Support ZoneOffset +h:mm in DateTimeUtils. getZoneId

[GitBox <gi...@apache.org>]

srowen commented on a change in pull request #31624:
URL: https://github.com/apache/spark/pull/31624#discussion_r582052309



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
##########
@@ -50,7 +50,10 @@ object DateTimeUtils {
 
   val TIMEZONE_OPTION = "timeZone"
 
-  def getZoneId(timeZoneId: String): ZoneId = ZoneId.of(timeZoneId, ZoneId.SHORT_IDS)
+  def getZoneId(timeZoneId: String): ZoneId = {
+    // To support the (+|-)h:mm format because it was supported before Spark 3.0.
+      ZoneId.of(timeZoneId.replaceFirst("(\\+|\\-)(\\d)(:)", "$10$2$3"), ZoneId.SHORT_IDS)

Review comment:
       Nit: unindent this line two spaces
   Capturing the colon as a group isn't needed. Just match it directly and write a literal colon in the replacement.
   The regex looks right; I'm just wondering if it can possibly accidentally match something else in the TZ. I can't think of it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org