You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Rabi Kumar K C (Jira)" <ji...@apache.org> on 2019/11/05 15:14:00 UTC

[jira] [Commented] (HBASE-18439) Subclasses of o.a.h.h.chaos.actions.Action all use the same logger

    [ https://issues.apache.org/jira/browse/HBASE-18439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16967602#comment-16967602 ] 

Rabi Kumar K C commented on HBASE-18439:
----------------------------------------

Assigning the ticket to myself as this has remained stale for a while. Will open a PR soon for this. Hopefully this is still required.

> Subclasses of o.a.h.h.chaos.actions.Action all use the same logger
> ------------------------------------------------------------------
>
>                 Key: HBASE-18439
>                 URL: https://issues.apache.org/jira/browse/HBASE-18439
>             Project: HBase
>          Issue Type: Bug
>          Components: integration tests
>            Reporter: Mike Drob
>            Assignee: Rabi Kumar K C
>            Priority: Minor
>              Labels: beginner
>
> A bunch of the actions all use the same logger inherited from the super class. We should have them declare distinct loggers, either each one in class or perhaps we can do something dynamically like {{LogFactory.getLogger(MethodHandles.lookup().lookupClass()}} and drop the static modifier on the log field.
> I'm not sure that exact incantation would actually work, but the MethodHandles approach in general is how logger resolution happens in Solr and it actually works out pretty well.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)