You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2023/04/21 05:32:01 UTC
[kudu-CR] [docs] fix instructions for building Kudu on SLES
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19779
Change subject: [docs] fix instructions for building Kudu on SLES
......................................................................
[docs] fix instructions for building Kudu on SLES
This patch fixes formatting errors and adds missing packages into the
list of required once to build and run Kudu on SLES. I just found
that some of the run-time packages were not in the list when trying
to run Kudu bits built on SLES15 SP4.
Change-Id: I2f080851c32cdc6c3b9ef393dfeb485d953d882e
---
M docs/installation.adoc
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/79/19779/1
--
To view, visit http://gerrit.cloudera.org:8080/19779
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2f080851c32cdc6c3b9ef393dfeb485d953d882e
Gerrit-Change-Number: 19779
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] [docs] fix instructions for building Kudu on SLES
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19779 )
Change subject: [docs] fix instructions for building Kudu on SLES
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19779/3/docs/installation.adoc
File docs/installation.adoc:
http://gerrit.cloudera.org:8080/#/c/19779/3/docs/installation.adoc@424
PS3, Line 424:
: . Install `gcc8` and `gcc8-c++` (might require activating Development Tools
: Module to add corresponding package repositories):
: +
: ----
: $ sudo zypper install gcc8 gcc8-c++
: ----
:
: . NOTE: If building on SLES 15, the system compiler (GCC7) may be used
: instead:
: +
: ----
: $ sudo zypper install gcc7 gcc7-c++
: ----
> OK, Thank you for your patient explanation.
'system compiler' doesn't mean it's installed by default. It means it's been used to compile all the bits in the system and it doesn't require any extra repo to add to fetch the package.
Basically, it's possible to install SLES15 so there isn't any C compiler installed, even the system one.
Also, even if gcc7 might be installed, gcc7-c++ might not be installed.
--
To view, visit http://gerrit.cloudera.org:8080/19779
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f080851c32cdc6c3b9ef393dfeb485d953d882e
Gerrit-Change-Number: 19779
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Tue, 02 May 2023 01:24:56 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] fix instructions for building Kudu on SLES
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Ashwani Raina, Yingchun Lai, Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19779
to look at the new patch set (#2).
Change subject: [docs] fix instructions for building Kudu on SLES
......................................................................
[docs] fix instructions for building Kudu on SLES
This patch fixes formatting errors and adds missing packages into the
list of required ones to build and run Kudu on SLES. I just found
that some of the run-time packages were not in the list when trying
to run Kudu bits built on SLES15 SP4.
Change-Id: I2f080851c32cdc6c3b9ef393dfeb485d953d882e
---
M docs/installation.adoc
1 file changed, 9 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/79/19779/2
--
To view, visit http://gerrit.cloudera.org:8080/19779
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2f080851c32cdc6c3b9ef393dfeb485d953d882e
Gerrit-Change-Number: 19779
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
[kudu-CR] [docs] fix instructions for building Kudu on SLES
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/19779 )
Change subject: [docs] fix instructions for building Kudu on SLES
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19779
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f080851c32cdc6c3b9ef393dfeb485d953d882e
Gerrit-Change-Number: 19779
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Mon, 01 May 2023 23:52:06 +0000
Gerrit-HasComments: No
[kudu-CR] [docs] fix instructions for building Kudu on SLES
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Ashwani Raina, Yingchun Lai, Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19779
to look at the new patch set (#3).
Change subject: [docs] fix instructions for building Kudu on SLES
......................................................................
[docs] fix instructions for building Kudu on SLES
This patch fixes formatting errors and adds missing packages into the
list of required ones to build and run Kudu on SLES. I just found
that some of the run-time packages were not in the list when trying
to run Kudu bits built on SLES15 SP4.
Change-Id: I2f080851c32cdc6c3b9ef393dfeb485d953d882e
---
M docs/installation.adoc
1 file changed, 25 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/79/19779/3
--
To view, visit http://gerrit.cloudera.org:8080/19779
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2f080851c32cdc6c3b9ef393dfeb485d953d882e
Gerrit-Change-Number: 19779
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
[kudu-CR] [docs] fix instructions for building Kudu on SLES
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19779 )
Change subject: [docs] fix instructions for building Kudu on SLES
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/19779/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19779/1//COMMIT_MSG@10
PS1, Line 10: once
> nit: ones
Done
http://gerrit.cloudera.org:8080/#/c/19779/1/docs/installation.adoc
File docs/installation.adoc:
http://gerrit.cloudera.org:8080/#/c/19779/1/docs/installation.adoc@413
PS1, Line 413: gcc8 gcc8-c++
> nit: Once http://gerrit.cloudera.org:8080/19778 is merged and available, we
Done
--
To view, visit http://gerrit.cloudera.org:8080/19779
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f080851c32cdc6c3b9ef393dfeb485d953d882e
Gerrit-Change-Number: 19779
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Mon, 24 Apr 2023 18:50:09 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] fix instructions for building Kudu on SLES
Posted by "Ashwani Raina (Code Review)" <ge...@cloudera.org>.
Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/19779 )
Change subject: [docs] fix instructions for building Kudu on SLES
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
http://gerrit.cloudera.org:8080/#/c/19779/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19779/1//COMMIT_MSG@10
PS1, Line 10: once
nit: ones
http://gerrit.cloudera.org:8080/#/c/19779/1/docs/installation.adoc
File docs/installation.adoc:
http://gerrit.cloudera.org:8080/#/c/19779/1/docs/installation.adoc@413
PS1, Line 413: gcc8 gcc8-c++
nit: Once http://gerrit.cloudera.org:8080/19778 is merged and available, we can perhaps add that gcc7 (as default system compiler) can also work if gcc8 is not installable for some reason.
--
To view, visit http://gerrit.cloudera.org:8080/19779
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f080851c32cdc6c3b9ef393dfeb485d953d882e
Gerrit-Change-Number: 19779
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Fri, 21 Apr 2023 07:25:22 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] fix instructions for building Kudu on SLES
Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/19779 )
Change subject: [docs] fix instructions for building Kudu on SLES
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19779/3/docs/installation.adoc
File docs/installation.adoc:
http://gerrit.cloudera.org:8080/#/c/19779/3/docs/installation.adoc@424
PS3, Line 424:
: . Install `gcc8` and `gcc8-c++` (might require activating Development Tools
: Module to add corresponding package repositories):
: +
: ----
: $ sudo zypper install gcc8 gcc8-c++
: ----
:
: . NOTE: If building on SLES 15, the system compiler (GCC7) may be used
: instead:
: +
: ----
: $ sudo zypper install gcc7 gcc7-c++
: ----
I am conflused about the gcc version.
According this doc,
< SLES 15, gcc8 gcc8-c++ is installed.
= SLES 15, gcc7 gcc7-c++ is installed.
Accoding this patch: https://gerrit.cloudera.org/c/19778/, If both GCC7 and GCC8 are present, prefer GCC8 over GCC7 to build Kudu.
So gcc8 is a common method?
If we need pick gcc7 in SLES 15. we should avoid installing gcc8.
If SLES15 has GCC7 as the system compiler, that means gcc7 is default present, and need not install?
--
To view, visit http://gerrit.cloudera.org:8080/19779
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f080851c32cdc6c3b9ef393dfeb485d953d882e
Gerrit-Change-Number: 19779
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Tue, 25 Apr 2023 04:06:17 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] fix instructions for building Kudu on SLES
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19779 )
Change subject: [docs] fix instructions for building Kudu on SLES
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19779/3/docs/installation.adoc
File docs/installation.adoc:
http://gerrit.cloudera.org:8080/#/c/19779/3/docs/installation.adoc@424
PS3, Line 424:
: . Install `gcc8` and `gcc8-c++` (might require activating Development Tools
: Module to add corresponding package repositories):
: +
: ----
: $ sudo zypper install gcc8 gcc8-c++
: ----
:
: . NOTE: If building on SLES 15, the system compiler (GCC7) may be used
: instead:
: +
: ----
: $ sudo zypper install gcc7 gcc7-c++
: ----
> If we need pick gcc7 in SLES 15. we should avoid installing gcc8.
On SLES it's possible to have multiple compiler installed simultaneously. Just FYI: https://www.suse.com/c/suse-linux-essentials-where-are-the-compilers-understanding-the-development-tools-module/
--
To view, visit http://gerrit.cloudera.org:8080/19779
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f080851c32cdc6c3b9ef393dfeb485d953d882e
Gerrit-Change-Number: 19779
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Tue, 25 Apr 2023 18:21:36 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] fix instructions for building Kudu on SLES
Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/19779 )
Change subject: [docs] fix instructions for building Kudu on SLES
......................................................................
Patch Set 3: Code-Review+1
> Patch Set 3:
>
> (1 comment)
ok, Thanks for your reply.
--
To view, visit http://gerrit.cloudera.org:8080/19779
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f080851c32cdc6c3b9ef393dfeb485d953d882e
Gerrit-Change-Number: 19779
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Tue, 02 May 2023 01:57:20 +0000
Gerrit-HasComments: No
[kudu-CR] [docs] fix instructions for building Kudu on SLES
Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/19779 )
Change subject: [docs] fix instructions for building Kudu on SLES
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19779/3/docs/installation.adoc
File docs/installation.adoc:
http://gerrit.cloudera.org:8080/#/c/19779/3/docs/installation.adoc@424
PS3, Line 424:
: . Install `gcc8` and `gcc8-c++` (might require activating Development Tools
: Module to add corresponding package repositories):
: +
: ----
: $ sudo zypper install gcc8 gcc8-c++
: ----
:
: . NOTE: If building on SLES 15, the system compiler (GCC7) may be used
: instead:
: +
: ----
: $ sudo zypper install gcc7 gcc7-c++
: ----
> > If we need pick gcc7 in SLES 15. we should avoid installing gcc8.
OK, Thank you for your patient explanation.
Because SLES15 has a system compiler gcc7, if the command 'sudo zypper install gcc7 gcc7-c++' need not run?
Maybe SLES15 have no gcc default?
--
To view, visit http://gerrit.cloudera.org:8080/19779
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f080851c32cdc6c3b9ef393dfeb485d953d882e
Gerrit-Change-Number: 19779
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Wed, 26 Apr 2023 03:19:24 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] fix instructions for building Kudu on SLES
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/19779 )
Change subject: [docs] fix instructions for building Kudu on SLES
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19779
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f080851c32cdc6c3b9ef393dfeb485d953d882e
Gerrit-Change-Number: 19779
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Mon, 24 Apr 2023 18:09:15 +0000
Gerrit-HasComments: No
[kudu-CR] [docs] fix instructions for building Kudu on SLES
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19779 )
Change subject: [docs] fix instructions for building Kudu on SLES
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19779/3/docs/installation.adoc
File docs/installation.adoc:
http://gerrit.cloudera.org:8080/#/c/19779/3/docs/installation.adoc@424
PS3, Line 424:
: . Install `gcc8` and `gcc8-c++` (might require activating Development Tools
: Module to add corresponding package repositories):
: +
: ----
: $ sudo zypper install gcc8 gcc8-c++
: ----
:
: . NOTE: If building on SLES 15, the system compiler (GCC7) may be used
: instead:
: +
: ----
: $ sudo zypper install gcc7 gcc7-c++
: ----
> I am conflused about the gcc version.
Yes, using GCC8 is a common method -- GCC8 can be used to build Kudu on both SLES versions (I guess at this time we are talking about SLES12 and SLES15).
What this doc is trying to say is that on SLES15 people can use GCC7 to build Kudu since GCC7 is a system compiler, so they don't need to enable/activate extra features and add extra package repositories (that would be the case if installing GCC8). Historically (i.e. starting SLES12), the recommended compiler on SLES for Kudu was GCC8, but since SLES15 now has C++17-capable system compiler, it can be used to compile Kudu.
Does it bring any clarity now?
Let me know what can be done to make this less confusing. Thanks!
--
To view, visit http://gerrit.cloudera.org:8080/19779
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f080851c32cdc6c3b9ef393dfeb485d953d882e
Gerrit-Change-Number: 19779
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Tue, 25 Apr 2023 18:18:49 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] fix instructions for building Kudu on SLES
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19779 )
Change subject: [docs] fix instructions for building Kudu on SLES
......................................................................
[docs] fix instructions for building Kudu on SLES
This patch fixes formatting errors and adds missing packages into the
list of required ones to build and run Kudu on SLES. I just found
that some of the run-time packages were not in the list when trying
to run Kudu bits built on SLES15 SP4.
Change-Id: I2f080851c32cdc6c3b9ef393dfeb485d953d882e
Reviewed-on: http://gerrit.cloudera.org:8080/19779
Tested-by: Kudu Jenkins
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
Reviewed-by: Yuqi Du <sh...@gmail.com>
---
M docs/installation.adoc
1 file changed, 25 insertions(+), 8 deletions(-)
Approvals:
Kudu Jenkins: Verified
Abhishek Chennaka: Looks good to me, approved
Yuqi Du: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.cloudera.org:8080/19779
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2f080851c32cdc6c3b9ef393dfeb485d953d882e
Gerrit-Change-Number: 19779
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR] [docs] fix instructions for building Kudu on SLES
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19779 )
Change subject: [docs] fix instructions for building Kudu on SLES
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19779
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f080851c32cdc6c3b9ef393dfeb485d953d882e
Gerrit-Change-Number: 19779
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Fri, 21 Apr 2023 06:50:12 +0000
Gerrit-HasComments: No